Skip to content

Graphics_Engine: Adding fallback method to IToSVGString(this IGeometry geometry) #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adecler
Copy link
Member

@adecler adecler commented Jan 6, 2023

Issues addressed by this PR

Closes #501

Test files

Simple code inspection is enough in this case

Additional comments

VS decided to automatically add a space between the if and he( but, other than that, this PR is only adding a fallback method without touching anything else.

@adecler adecler added the type:compliance Non-conforming to code guidelines label Jan 6, 2023
@adecler adecler self-assigned this Jan 6, 2023
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and looks good, only spacing as mentioned and the fallback method which looks good for handling null and the type - happy to deploy.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 7, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 7, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check unit-tests
@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 8, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests
  • check dataset-compliance
  • check copyright-compliance
  • check ready-to-merge

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: documentation-compliance, copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 8, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 3829de1 into develop Jan 8, 2023
@FraserGreenroyd FraserGreenroyd deleted the Graphics_Engine-#501-FallbackToInterfaceMethod branch January 8, 2023 00:59
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
@FraserGreenroyd FraserGreenroyd changed the title Adding fallback method to IToSVGString(this IGeometry geometry) Graphics_Engine: Adding fallback method to IToSVGString(this IGeometry geometry) Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG_Engine: Interface method does not cover all the types
2 participants