Skip to content

Reflection_Engine: add method to collect all base types of a type #2974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

alelom
Copy link
Member

@alelom alelom commented Jan 3, 2023

Issues addressed by this PR

Closes #2973

Test files

See BHoM/BHoM_Adapter#332

Changelog

Additional comments

@alelom alelom requested a review from IsakNaslundBh January 3, 2023 14:12
@alelom alelom self-assigned this Jan 3, 2023
@alelom alelom added the type:feature New capability or enhancement label Jan 3, 2023
@alelom alelom changed the title Reflection_Engine: add BaseTypes to collect all base types of a type Reflection_Engine: add method to collect all base types of a type Jan 3, 2023
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tweaks to where things go to align with other parts of the engine.

@alelom alelom requested a review from IsakNaslundBh January 3, 2023 14:54
@IsakNaslundBh
Copy link
Contributor

Happy with this now. Will approve when a UT has been added

@FraserGreenroyd
Copy link
Contributor

For this PR, make sure the unit test only uses types available to the repository if you only built this repository and its dependencies, in this case, BHoM. Don't fall into the trap I did when doing types based unit tests and thinking I could use any type I had on my machine 😄

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 24 requests in the queue ahead of you.

@alelom alelom requested a review from rwemay as a code owner January 4, 2023 09:34
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this after code review and testing

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 178 requests in the queue ahead of you.

@alelom
Copy link
Member Author

alelom commented Jan 4, 2023

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@alelom to confirm, the following actions are now queued:

  • check installer

There are 9 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning
@BHoMBot check unit-tests
@BHoMBot check serialisation
@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check unit-tests
  • check serialisation
  • check core
  • check null-handling
  • check ready-to-merge

There are 64 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for this to go in, worked/seen working with @alelom and @IsakNaslundBh during PR closure call.

@FraserGreenroyd FraserGreenroyd merged commit 75530d8 into develop Jan 4, 2023
@FraserGreenroyd FraserGreenroyd deleted the Reflection_Engine-#2973-BaseTypes branch January 4, 2023 17:07
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflection_Engine: add method to collect all base types of a type
3 participants