-
Notifications
You must be signed in to change notification settings - Fork 13
Reflection_Engine: add method to collect all base types of a type #2974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tweaks to where things go to align with other parts of the engine.
Happy with this now. Will approve when a UT has been added |
For this PR, make sure the unit test only uses types available to the repository if you only built this repository and its dependencies, in this case, BHoM. Don't fall into the trap I did when doing types based unit tests and thinking I could use any type I had on my machine 😄 |
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 24 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this after code review and testing
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 178 requests in the queue ahead of you. |
@BHoMBot check installer |
@alelom to confirm, the following actions are now queued:
There are 9 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 64 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy for this to go in, worked/seen working with @alelom and @IsakNaslundBh during PR closure call.
Issues addressed by this PR
Closes #2973
Test files
See BHoM/BHoM_Adapter#332
Changelog
Additional comments