-
Notifications
You must be signed in to change notification settings - Fork 13
Serialiser_Engine: added null check in MethodBaseSerialiser #2963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialiser_Engine: added null check in MethodBaseSerialiser #2963
Conversation
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 10 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds the braces that @adecler requested on the previous iteration of this PR, so this is good to go now for beta.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 13 requests in the queue ahead of you. |
The check |
Issues addressed by this PR
Closes #2823
Added a null check in MethodBaseSerializer to avoid it throwing an exception during startup (plugin loading) as explained in #2823.
Test files
See #2823. I can provide an assembly that throws the error if deemed necessary.
Changelog