Skip to content

Serialiser_Engine: added null check in MethodBaseSerialiser #2963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alelom
Copy link
Member

@alelom alelom commented Dec 14, 2022

Issues addressed by this PR

Closes #2823

Added a null check in MethodBaseSerializer to avoid it throwing an exception during startup (plugin loading) as explained in #2823.

Test files

See #2823. I can provide an assembly that throws the error if deemed necessary.

Changelog

@alelom alelom self-assigned this Dec 14, 2022
@alelom alelom added the type:bug Error or unexpected behaviour label Dec 14, 2022
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 10 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required
@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer
  • check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds the braces that @adecler requested on the previous iteration of this PR, so this is good to go now for beta.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 13 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 14, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd FraserGreenroyd merged commit 43ee03d into main Dec 14, 2022
@FraserGreenroyd FraserGreenroyd deleted the #2823-MethodBaseSerialiserExceptionOnStartupRedone branch December 14, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialiser_Engine: missing null check in MethodBaseSerialiser, throws exception on startup
2 participants