Geometry_Engine: Add controls to external edges for mesh

[IsakNaslundBh]

NOTE: Depends on

Issues addressed by this PR

Closes #2956

Update external edge method for Mesh to support getting Edges out by topology or geometry.

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/ElVIwxksipROv3GK94FTYQwBXbEHfFy1Z8gk-8bz7QtN1A?e=NwaeVy

Changelog

Additional comments

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[IsakNaslundBh]

@BHoMBot check compliance
@BHoMBot check unit-tests

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check unit-tests

There are 4 requests in the queue ahead of you.

[IsakNaslundBh]

@BHoMBot check required

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

[pawelbaran]

I have left a few minor comments to the code. Additionally, I would rather spend 1 minute to add missing input descriptions (should be really simple in this case) and be done with it 🙈

[pawelbaran]

@BHoMBot check compliance

[bhombot-ci]

@pawelbaran to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[IsakNaslundBh]

@BHoMBot check compliance

[bhombot-ci]

@IsakNaslundBh to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[pawelbaran]

Happy with the code and functionality, with one minor comment: during testing I have found out that ExternalEdges for meshes returns only the edges that adjoin to only one face, which makes perfect sense, but is counterintuitive in case of three-dimensional meshes, i.e. for a cuboidal mesh the method would return an empty collection, while one could possibly expect the edges of the cuboid. This could be explained a bit better in the description to avoid confusion on the user's side.

[FraserGreenroyd]

@BHoMBot check required
@BHoMBot check unit-tests

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer
• check unit-tests

There are 228 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

@BHoMBot check ready-to-merge

[bhombot-ci]

@FraserGreenroyd to confirm, the following actions are now queued:

• check ready-to-merge

There are 10 requests in the queue ahead of you.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.