Skip to content

Serialiser_Engine: Fix ToJson for null Name property #2939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #2938

Test files

{
	Name: null
}

Try converting this JSON string FromJson and then immediately ToJson on main and then on this PR. You should find it throws an error on main but this branch will continue.

image

Changelog

Additional comments

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 1, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check unit-tests
@BHoMBot check core
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 1, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check unit-tests
  • check core
  • check null-handling

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check serialisation
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 1, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation
  • check versioning

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the example provided and can this PR fixes the issue.
Code change makes sense.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 2, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 8de7db3 into main Nov 2, 2022
@FraserGreenroyd FraserGreenroyd deleted the Serialiser_Engine-#2938-NullName branch November 2, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialiser_Engine: Bug when converting object with null name property
2 participants