-
Notifications
You must be signed in to change notification settings - Fork 13
Spatial_Engine: Add Orient method for IElements #2924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spatial_Engine: Add Orient method for IElements #2924
Conversation
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 20 requests in the queue ahead of you. |
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 18 requests in the queue ahead of you. |
@BHoMBot check unit-tests |
@BHoMBot check unit-tests |
@IsakNaslundBh to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve following the review made and discussion successfully resolved 👍
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
The check |
@BHoMBot this is a DevOps instruction. I am requesting a force check on: versioning |
@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP. |
@FraserGreenroyd I have provided force checks to the checks requested. |
1 similar comment
@IsakNaslundBh to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #2923
Closes #2925
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/Eq_NayBBG7RNhDlbSgaQmD0BFSZdeP7w_QY68UITtETTnQ?e=QXSMRg
Changelog
Additional comments
Was debating with myself if providing null to from or to should default to world XY. That way it would be simpler to go from global to local, or vice versa. (not having to provide a global XY plane in one of the inputs). I opted out of it due to the Orient method in Geometry_Engine not behaving this way, but happy to change if we want to. @pawelbaran @al-fisher happy with comments on this.