Skip to content

Spatial_Engine: Add Orient method for IElements #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 11, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Oct 6, 2022

Issues addressed by this PR

Closes #2923
Closes #2925

  • Adds method for Orienting Elements.
  • Fix cloning issue with facade FrameEdge

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Eq_NayBBG7RNhDlbSgaQmD0BFSZdeP7w_QY68UITtETTnQ?e=QXSMRg

Changelog

Additional comments

Was debating with myself if providing null to from or to should default to world XY. That way it would be simpler to go from global to local, or vice versa. (not having to provide a global XY plane in one of the inputs). I opted out of it due to the Orient method in Geometry_Engine not behaving this way, but happy to change if we want to. @pawelbaran @al-fisher happy with comments on this.

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Oct 6, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Oct 6, 2022
@IsakNaslundBh
Copy link
Contributor Author

IsakNaslundBh commented Oct 6, 2022

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 6, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 7, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 20 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Oct 7, 2022
@IsakNaslundBh IsakNaslundBh requested a review from enarhi October 7, 2022 07:56
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 7, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 18 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check unit-tests

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 10, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check unit-tests

There are 5 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 10, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 10, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 10, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 10, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 1 requests in the queue ahead of you.

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve following the review made and discussion successfully resolved 👍

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 10, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 10, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting a force check on: versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 10, 2022

@FraserGreenroyd I am now running force checks on the checks requested. These will be queued and actioned ASAP.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 10, 2022

@FraserGreenroyd I have provided force checks to the checks requested.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check ready-to-merge

1 similar comment
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 11, 2022

@IsakNaslundBh to confirm, the following actions are now queued:

  • check core
  • check serialisation
  • check ready-to-merge

There are 4 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit b5b0e12 into main Oct 11, 2022
@IsakNaslundBh IsakNaslundBh deleted the Spatial_Engine-#2923-AddOrientMethodForIElements branch October 11, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Facade_Engine: Transform of FrameEdge not cloning FrameEdgeProperty properly Spatial_Engine: Add Orient method to IElements
3 participants