BHoM_Engine: fix Hash() method not working with CustomObjects

[alelom]

Issues addressed by this PR

Closes #2844

The issue was that there was an old piece of code in the Hash function that was supposed to grab the Key of the CustomData dictionary when the input object was a CustomObject, to then determine what to do with this key. This part was not implemented properly. It was not discovered earlier due to lack of usage of this workflow. This is now fixed by moving the code in the correct area of the algorithm. I also added tests in the DiffingTests prototypes to capture this usage, see below.

Test files

• See BHoM_Engine: Hash generation is crashing for CustomObjects #2844 (simply try to compute the Hash of any CustomObject) and/or
• run the DiffingTests in https://github.com/BHoM/DiffingTests_Prototypes. There are two new tests that cover this workflow within the HashTests class: CustomObjects_EqualHash and CustomObjects_CustomKeyException_DifferentObjs_EqualHash.

Changelog

Additional comments

[IsakNaslundBh]

Tests in diffing prototypes is passing.

Am now able to compute the Hash of a Custom object that is consistent with inputs changing. Approved

[alelom]

@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@alelom to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance
• code-compliance
• documentation-compliance
• project-compliance
• core
• null-handling
• serialisation
• versioning
• installer

There are 48 requests in the queue ahead of you.

[alelom]

@BHoMBot check ready-to-merge

[bhombot-ci]

@alelom to confirm, the following checks are now queued:

• ready-to-merge

There are 63 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.