Skip to content

Base_Engine: Making SetGeometry call TryRunExtensionMethod #2778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Mar 16, 2022

Issues addressed by this PR

Closes #2777

This method was not doing anything before and not even raising any warnings/errors that that was the case. Made sure it it correctly tries to dispatch to a SetGeometry method compatible with the object type and geometry type provided, and if failing to do so, raises an error.

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/BHoM_Engine/%232778-ISetGeometry-to-call-TryRunExtensionMethod?csf=1&web=1&e=aa36GG

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Mar 16, 2022
@IsakNaslundBh IsakNaslundBh requested a review from adecler as a code owner March 16, 2022 12:00
@IsakNaslundBh IsakNaslundBh self-assigned this Mar 16, 2022
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • null-handling

There are 2 requests in the queue ahead of you.

Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2022

The check null-handling has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good improvement to UX, good catch @IsakNaslundBh 😄

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 16, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 1 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit b5a0ab6 into main Mar 16, 2022
@IsakNaslundBh IsakNaslundBh deleted the Base_Engine-#2777-ISetGeometry-to-call-TryRunExtensionMethod branch March 16, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base_Engine: ISetGeometry to call TryRunExtensionMethod
3 participants