-
Notifications
You must be signed in to change notification settings - Fork 13
Base_Engine: Making SetGeometry call TryRunExtensionMethod #2778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Base_Engine: Making SetGeometry call TryRunExtensionMethod #2778
Conversation
@IsakNaslundBh to confirm, the following checks are now queued:
There are 2 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected
@BHoMBot check required |
@IsakNaslundBh to confirm, the following checks are now queued:
|
The check |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good improvement to UX, good catch @IsakNaslundBh 😄
@BHoMBot check ready-to-merge |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 1 requests in the queue ahead of you. |
Issues addressed by this PR
Closes #2777
This method was not doing anything before and not even raising any warnings/errors that that was the case. Made sure it it correctly tries to dispatch to a SetGeometry method compatible with the object type and geometry type provided, and if failing to do so, raises an error.
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/BHoM_Engine/BHoM_Engine/%232778-ISetGeometry-to-call-TryRunExtensionMethod?csf=1&web=1&e=aa36GG
Changelog
Additional comments