Skip to content

Spatial_Engine: Adding Geometry method for shapeprofiles #2735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 17, 2022
Merged

Spatial_Engine: Adding Geometry method for shapeprofiles #2735

merged 3 commits into from
Jan 17, 2022

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Jan 17, 2022 •
edited
Loading

Issues addressed by this PR

Closes #2600

Adding Geometry method for ShapeProfiles to make them automatically visible in UIs

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EjrFiU9GGw1Ik9_YKrViltkBvnp8YFZH3s8mN6vOiXMJOQ?e=QQrGJt

Changelog

Additional comments

@IsakNaslundBh
Adding Geometry method for shapeprofiles
dc324ba 
Makes them automatically visible in UIs
@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Jan 17, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 17, 2022
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

FraserGreenroyd
FraserGreenroyd reviewed Jan 17, 2022
View reviewed changes
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 36 requests in the queue ahead of you.

FraserGreenroyd
FraserGreenroyd approved these changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM following discussions with @IsakNaslundBh

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • ready-to-merge

There are 48 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit 78a1731 into main Jan 17, 2022
@IsakNaslundBh IsakNaslundBh deleted the Spatial_Engine-#2600-GeometryMethodForShapeProfiles branch January 17, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@pawelbaran pawelbaran Awaiting requested review from pawelbaran pawelbaran is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spatial_Engine: Add Geometry method for Profiles
2 participants
@IsakNaslundBh @FraserGreenroyd