Skip to content

Remove PreviousVersion Attributes #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 5, 2022
Merged

Remove PreviousVersion Attributes #2723

merged 1 commit into from
Jan 5, 2022

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Jan 5, 2022

Remove PreviousVersion attributes for 5.0 versioning.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 5, 2022
FraserGreenroyd
FraserGreenroyd approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from a DevOps perspective, will be merged when the bot is back online.

IsakNaslundBh
IsakNaslundBh approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 13 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check dataset-compliance
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • dataset-compliance
  • copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

There are 9 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is copyright-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 4717253203

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a CI/CD instruction. I am authorising dispensation to be granted on check ref. 4717253203

BHoMBot is about to do automatic copyright updates so dispensating for now for the bot to handle.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 5, 2022

@FraserGreenroyd I have now provided a passing check on reference 4717253203 as requested.

@FraserGreenroyd FraserGreenroyd merged commit 2bb3693 into main Jan 5, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM-RemovePreviousVersion50 branch January 5, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@IsakNaslundBh IsakNaslundBh IsakNaslundBh approved these changes

@adecler adecler Awaiting requested review from adecler adecler is a code owner

@al-fisher al-fisher Awaiting requested review from al-fisher al-fisher is a code owner

@alelom alelom Awaiting requested review from alelom alelom is a code owner

@rwemay rwemay Awaiting requested review from rwemay rwemay is a code owner

@tg359 tg359 Awaiting requested review from tg359 tg359 is a code owner

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BHoMBot @FraserGreenroyd @IsakNaslundBh