Skip to content

Diffing_Engine: alignments to changes to ComparisonConfig; minor bug fixes #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 10, 2021

Conversation

alelom
Copy link
Member

@alelom alelom commented Dec 9, 2021

NOTE: Depends on

BHoM/BHoM#1333

Issues addressed by this PR

Closes #2716
Closes #2717

Test files

Just run the following test file:
https://burohappold.sharepoint.com/:f:/s/BHoM/Epjl618V1IpNn0uEae_uFR0Bey9CYMXSDPNE-iUFuyYYoQ?e=bJt14l

and check that the panels correctly contains the objects as per text:
image

The correct execution of this test file guarantees that all changes in this PR work correctly. Further testing is not needed, but more tests can be found in:
https://burohappold.sharepoint.com/:f:/s/BHoM/ElkWAuBU0CpNhyNhwF96LlEBqkxJgHX3AhBOGlnA4bBwag?e=Kr2FMc

Changelog

  • Aligned the Diffing_Engine and base BHoM_Engine to the renamed ComparisonConfig.CustomDataToConsider
  • Bug fix in ObjectDifferences(): ComparisonConfig.NameSpaceExceptions now correctly used
  • Bug fix in ObjectDifferences(): ComparisonConfig.MaxNesting now correctly used
  • IDiffing: minor bug fix in incorrect dispatching object
  • Minor bug fix in DiffingWithHash: null checks, result better display of result

@alelom alelom self-assigned this Dec 9, 2021
@alelom alelom added type:bug Error or unexpected behaviour type:compliance Non-conforming to code guidelines labels Dec 9, 2021
@bhombot-ci
Copy link

bhombot-ci bot commented Dec 9, 2021

@alelom just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 9, 2021

@alelom just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @alelom on BHoM

alelom added a commit to BHoM/DiffingTests_Prototypes that referenced this pull request Dec 9, 2021
@alelom
Copy link
Member Author

alelom commented Dec 10, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 10, 2021

@alelom to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

Copy link
Member

@kayleighhoude kayleighhoude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

All good on my end

@alelom
Copy link
Member Author

alelom commented Dec 10, 2021

@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 10, 2021

@alelom to confirm, the following checks are now queued:

  • copyright-compliance
  • dataset-compliance
  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 82c1276 into main Dec 10, 2021
@FraserGreenroyd FraserGreenroyd deleted the BHoM-#1331-ComparisonConfigPropertiesRevision branch December 10, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour type:compliance Non-conforming to code guidelines
Projects
None yet
3 participants