-
Notifications
You must be signed in to change notification settings - Fork 13
Reflection_Engine: LoadAllAssemblies fixed to load assemblies with dot in name #2713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflection_Engine: LoadAllAssemblies fixed to load assemblies with dot in name #2713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor fix needed otherwise looks good.
5dfe540
to
75794ed
Compare
@BHoMBot check required |
@pawelbaran to confirm, the following checks are now queued:
|
@BHoMBot check null-handling |
@pawelbaran to confirm, the following checks are now queued:
There are 30 requests in the queue ahead of you. |
@pawelbaran to confirm, the following checks are now queued:
There are 65 requests in the queue ahead of you. |
FAO: @FraserGreenroyd The check they wish to have dispensation on is copyright-compliance. If you are providing dispensation on this occasion, please reply with:
|
@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 4743358611 This was handled in a prior PR and will risk conflict to fix it here too. |
@FraserGreenroyd I have now provided a passing check on reference |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following checks are now queued:
|
Issues addressed by this PR
Closes #2712
Test files
On SharePoint.
Changelog
Additional comments
This bug should not affect the Beta release (it was found while working on BHoM/Revit_Toolkit#1137), so I am not pushing it - up to the framework lead whether worth merging now or after the end of the milestone @FraserGreenroyd.