Skip to content

Reflection_Engine: LoadAllAssemblies fixed to load assemblies with dot in name #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

pawelbaran
Copy link
Member

@pawelbaran pawelbaran commented Dec 7, 2021

Issues addressed by this PR

Closes #2712

Test files

On SharePoint.

Changelog

Additional comments

This bug should not affect the Beta release (it was found while working on BHoM/Revit_Toolkit#1137), so I am not pushing it - up to the framework lead whether worth merging now or after the end of the milestone @FraserGreenroyd.

@pawelbaran pawelbaran added the type:bug Error or unexpected behaviour label Dec 7, 2021
@pawelbaran pawelbaran requested a review from al-fisher as a code owner December 7, 2021 17:39
@pawelbaran pawelbaran self-assigned this Dec 7, 2021
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fix needed otherwise looks good.

@pawelbaran pawelbaran force-pushed the Reflection_Engine-#2712-LoadAssembliesWithDots branch from 5dfe540 to 75794ed Compare January 7, 2022 11:07
@pawelbaran pawelbaran requested a review from adecler January 7, 2022 11:12
@pawelbaran
Copy link
Member Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 7, 2022

@pawelbaran to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@pawelbaran
Copy link
Member Author

@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 7, 2022

@pawelbaran to confirm, the following checks are now queued:

  • null-handling

There are 30 requests in the queue ahead of you.

@pawelbaran
Copy link
Member Author

@BHoMBot check installer
@BHoMBot check serialisation
@BHoMBot check versioning
@BHoMBot check copyright-compliance
@BHoMBot check dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 7, 2022

@pawelbaran to confirm, the following checks are now queued:

  • installer
  • serialisation
  • versioning
  • copyright-compliance
  • dataset-compliance

There are 65 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 10, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is copyright-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 4743358611

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 4743358611

This was handled in a prior PR and will risk conflict to fix it here too.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 10, 2022

@FraserGreenroyd I have now provided a passing check on reference 4743358611 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 10, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit a79c5ec into main Jan 10, 2022
@FraserGreenroyd FraserGreenroyd deleted the Reflection_Engine-#2712-LoadAssembliesWithDots branch January 10, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reflection_Engine: LoadAllAssemblies does not load assemblies with dot in name
3 participants