Skip to content

Environment_Engine: Create openings from a panel #2635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

robinflyman
Copy link
Contributor

Closes #2595

Created a method to create openings from a panel.

@robinflyman robinflyman added the type:feature New capability or enhancement label Sep 30, 2021
@robinflyman robinflyman self-assigned this Sep 30, 2021
@robinflyman robinflyman requested a review from tg359 as a code owner September 30, 2021 13:52
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggested changes - feel free to reach out for a chat about this @robinflyman - it's a good start, but think we can improve it slightly before merging and deploying via alphas for users 😄

@robinflyman robinflyman force-pushed the Environment_Engine-#2595-CreateOpeningFromAPanelMethod branch from c06b043 to be5dafa Compare December 2, 2021 16:31
@robinflyman
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Dec 2, 2021

@robinflyman to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

There are 41 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2022

Please be advised that the check with reference 4806913507 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 303 additional annotations waiting, made up of 303 errors and 0 warnings.

@FraserGreenroyd FraserGreenroyd force-pushed the Environment_Engine-#2595-CreateOpeningFromAPanelMethod branch from 13dd886 to edaed7f Compare January 17, 2022 11:20
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

Final commit was only to copyright, all checks had passed that were required on the previous commit. Am therefore granting neutral checks to avoid over using bot resource.

@FraserGreenroyd
Copy link
Contributor

FraserGreenroyd commented Jan 17, 2022

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, versioning, installer, project-compliance, ready-to-merge, documentation-compliance, code-compliance, null-handling, dataset-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 17, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now from code review, this solves the issue raised.

@FraserGreenroyd FraserGreenroyd merged commit 4033828 into main Jan 17, 2022
@FraserGreenroyd FraserGreenroyd deleted the Environment_Engine-#2595-CreateOpeningFromAPanelMethod branch January 17, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environment_Engine: Glazing panel type
2 participants