-
Notifications
You must be signed in to change notification settings - Fork 13
Environment_Engine: Create openings from a panel #2635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment_Engine: Create openings from a panel #2635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggested changes - feel free to reach out for a chat about this @robinflyman - it's a good start, but think we can improve it slightly before merging and deploying via alphas for users 😄
c06b043
to
be5dafa
Compare
@BHoMBot check required |
@robinflyman to confirm, the following checks are now queued:
There are 41 requests in the queue ahead of you. |
@BHoMBot check required |
@FraserGreenroyd to confirm, the following checks are now queued:
|
Please be advised that the check with reference 4806913507 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 303 additional annotations waiting, made up of 303 errors and 0 warnings. |
13dd886
to
edaed7f
Compare
@BHoMBot check core |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot check required |
@FraserGreenroyd to confirm, the following checks are now queued:
|
The check |
Final commit was only to copyright, all checks had passed that were required on the previous commit. Am therefore granting neutral checks to avoid over using bot resource. |
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, versioning, installer, project-compliance, ready-to-merge, documentation-compliance, code-compliance, null-handling, dataset-compliance |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, the following checks are now queued:
|
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: serialisation |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now from code review, this solves the issue raised.
Closes #2595
Created a method to create openings from a panel.