Skip to content

Updates to FrameEdgeProperties Dataset #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vgreen-BH
Copy link
Contributor

Issues addressed by this PR

Closes #134

Updates to dataset

  • Fixed bounding box to allow Operable Window profiles to work with ExtendMullion method
  • Changed naming of fixed window and operable windows
  • Updated u-values to represent IGUs with warm edge spacers

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/BHoM_Datasets/Facade%20Datasets/230209_Extend%20Mullion%20Test%20File.gh?csf=1&web=1&e=Hhd7Wh

@vgreen-BH vgreen-BH added the type:bug Error or unexpected behaviour label Feb 10, 2023
@vgreen-BH vgreen-BH added this to the BHoM 6.1 β MVP milestone Feb 10, 2023
@vgreen-BH vgreen-BH requested a review from enarhi February 10, 2023 01:08
@vgreen-BH vgreen-BH self-assigned this Feb 10, 2023
Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested properties for bounding box depth changes and spot checked values.

@enarhi
Copy link
Member

enarhi commented Feb 10, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@enarhi
Copy link
Member

enarhi commented Feb 10, 2023

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@enarhi to confirm, the following actions are now queued:

  • check ready-to-merge

@enarhi
Copy link
Member

enarhi commented Feb 10, 2023

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 10, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit b0ed6fe into develop Feb 10, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Datasets-#134-UpdateFrameEdgeProperties branch February 10, 2023 23:19
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Updates to Facade FrameEdgeProperties Dataset
3 participants