Add FrameEdgeProperties to Facade datasets #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added FrameEdgeProperty dataset. Removed outdated datasets.
|
@BHoMBot check compliance |
|
@enarhi to confirm, the following checks are now queued:
|
Datasets updated to include author and confidence level
|
@BHoMBot check compliance |
|
@enarhi to confirm, the following checks are now queued:
|
enarhi
approved these changes
Mar 3, 2022
|
Closes #117 |
FraserGreenroyd
changed the title
FraserGreenroyd
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on Facade_oM #1363
Issues addressed by this PR
Closes #112
Adds generic datasets for FrameEdgeProperties and GlazingConstructions
Test Files
https://burohappold.sharepoint.com/sites/BHoM/02_Current/Forms/AllItems.aspx?csf=1&web=1&e=HlvYHp&cid=ab402372%2D7702%2D48ef%2Db6bc%2D9c3f66547c0a&RootFolder=%2Fsites%2FBHoM%2F02%5FCurrent%2F12%5FScripts%2F03%5FAlpha%2FBHoM%2FBHoM%5FDatasets%2FFacade%20Datasets&FolderCTID=0x0120008122C8891F89054B8ACED0196C70DFC4