Adding confidence to UK_SteelSections #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check dataset-compliance |
|
@IsakNaslundBh to confirm, the following checks are now queued:
|
peterjamesnugent
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
LGTM.
Outside the scope of this PR, the warping constant for the PFC Channels are incorrect and do not match the catalogue values - issued raised here: BHoM/BHoM_Engine#2669.
Iw for PFC channels
IsakNaslundBh
deleted the
BHoM_Datasets-#103-AddingCOnfidenceToUKSteelSections
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #103
Adding confidence level of High to UK_Steelsections
Test files
Motivating High confidence by testing procedure outlined in https://burohappold.sharepoint.com/:w:/s/BHoM/ETOYus919rdGtnjM9fFnMIsBFp8dQF0BTvEibhAZgVBcXQ?e=5L06Ba
Changelog
Additional comments