Skip to content

Add import to the execute actions #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 9, 2025
Merged

Add import to the execute actions #401

merged 3 commits into from
Apr 9, 2025

Conversation

EmmaSander
Copy link
Contributor

@EmmaSander EmmaSander commented Apr 4, 2025

Issues addressed by this PR

Closes #400

Sets up import as a global execute action.

Test files

Changelog

  • Added ImportFile execute action for adapters to import supported file types.

Additional comments

@EmmaSander EmmaSander added the type:feature New capability or enhancement label Apr 4, 2025
@EmmaSander EmmaSander self-assigned this Apr 4, 2025
@alelom alelom self-requested a review April 5, 2025 08:43
Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I'd just consider a different name.

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy @alelom's suggestion was implemented and tested with MidasCivil implementation.

@peterjamesnugent
Copy link
Member

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Apr 9, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check ready-to-merge

@alelom alelom merged commit 93607d2 into develop Apr 9, 2025
9 checks passed
@alelom alelom deleted the #400-AddImportAction branch April 9, 2025 22:55
@BHoMBot BHoMBot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an ExecuteAction for Import
3 participants