-
Notifications
You must be signed in to change notification settings - Fork 5
BHoM_Adapter: Adding Before and After methods for each action #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following discussion with @alelom, can we add, to each description (including the other additional methods within each file), the following sentence:
This method is intended to be called by the context in which this Adapter is run, which typically is a UI supported by BHoM.
@BHoMBot check required |
@albinber to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these changes, which I believe will make adapters more flexible.
The code changes look good, and they work (tested with the File_Adapter test scripts).
@BHoMBot check copyright-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great on code review, thanks @albinber 😄
@albinber just to let you know, I have provided a |
NOTE: Depends on
Not directly dependant, but a related BHoM_UI PR uses these new methods, required for testing in the UI.
BHoM/BHoM_UI#481
Issues addressed by this PR
Closes #383
Introducing "before" and "after" methods for adapter actions following discussion between @FraserGreenroyd and @alelom.
Test files
Changelog
Additional comments