Skip to content

BHoM_Adapter: Adding Before and After methods for each action #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 19, 2024

Conversation

albinber
Copy link
Contributor

@albinber albinber commented Feb 19, 2024

NOTE: Depends on

Not directly dependant, but a related BHoM_UI PR uses these new methods, required for testing in the UI.
BHoM/BHoM_UI#481

Issues addressed by this PR

Closes #383

Introducing "before" and "after" methods for adapter actions following discussion between @FraserGreenroyd and @alelom.

Test files

Changelog

Additional comments

@albinber albinber added the type:feature New capability or enhancement label Feb 19, 2024
@albinber albinber self-assigned this Feb 19, 2024
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following discussion with @alelom, can we add, to each description (including the other additional methods within each file), the following sentence:

This method is intended to be called by the context in which this Adapter is run, which typically is a UI supported by BHoM.

@albinber
Copy link
Contributor Author

@BHoMBot check required

Copy link

bhombot-ci bot commented Feb 19, 2024

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes, which I believe will make adapters more flexible.

The code changes look good, and they work (tested with the File_Adapter test scripts).

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Feb 19, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on code review, thanks @albinber 😄

Copy link

bhombot-ci bot commented Feb 19, 2024

@albinber just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_UI

@FraserGreenroyd FraserGreenroyd merged commit a316200 into develop Feb 19, 2024
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Adapter-#383-PreActions branch February 19, 2024 17:20
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BHoM_Adapter: introduce "before" and "after" virtual methods for Adapter Actions
3 participants