Skip to content

Add username property to UsageEntry #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

adecler
Copy link
Member

@adecler adecler commented Nov 25, 2024

Issues addressed by this PR

Fixes #85

This adds the capture of the username on top of the computer ID.

Test files

After compiling this code, make sure to use one of our BHoM UIs. This will generate new log files that will be pushed to our database.

To test that this worked, you can connect to the Mongo database to check that the entries are now containing your username.
The simplest Mongo query to check the result is db.getCollection("UsageData").find({}).sort({_id: -1}) .

@adecler adecler added the type:feature New capability or enhancement label Nov 25, 2024
@adecler adecler requested a review from michaelhoehn November 25, 2024 16:10
@adecler adecler self-assigned this Nov 25, 2024
Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have tested and verified that both username and computer are coming through as expected. Happy to approve. LGTM 👍

@adecler
Copy link
Member Author

adecler commented Nov 27, 2024

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Nov 27, 2024

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@adecler
Copy link
Member Author

adecler commented Nov 27, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Nov 27, 2024

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Nov 27, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Nov 27, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@pawelbaran
Copy link
Member

@BHoMBot check versioning

Copy link

bhombot-ci bot commented Nov 28, 2024

@pawelbaran to confirm, the following actions are now queued:

  • check versioning

There are 55 requests in the queue ahead of you.

@adecler
Copy link
Member Author

adecler commented Nov 28, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Nov 28, 2024

@adecler to confirm, the following actions are now queued:

  • check ready-to-merge

@adecler adecler merged commit a4c2688 into develop Nov 28, 2024
12 checks passed
@adecler adecler deleted the BHoMAnalytics_Toolkit-#85-Username branch November 28, 2024 14:31
@BHoMBot BHoMBot mentioned this pull request Dec 9, 2024
@michaelhoehn michaelhoehn restored the BHoMAnalytics_Toolkit-#85-Username branch March 18, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add username property to UsageEntry
3 participants