Skip to content

Add link to project database for analytics #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2022

Conversation

FraserGreenroyd
Copy link

Issues addressed by this PR

Fixes #43

Test files

N/A

Steps to test:

  1. Be connected to the VPN or on network
  2. On this PR, load a script that will trigger the pop-up
  3. See that the project ID input is now a filterable combo-box
  4. Try filtering to a known project - for the benefits of testing use 0000000 project ID if you wish to test the confirm option
  5. Try entering a new project ID (one that isn't filterable) to see that new projects can be input

Second test:

  1. Be not connected to the VPN or on network
  2. Test that you can input a project ID as previous without any errors from not being able to access the project database

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Oct 3, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Oct 3, 2022
@FraserGreenroyd
Copy link
Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 8675863275

@FraserGreenroyd
Copy link
Author

@BHoMBot fix project file ref. 8675863275

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 8676040222

@FraserGreenroyd
Copy link
Author

@BHoMBot fix copyright headers ref. 8676040222

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 4 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check versioning

There are 11 requests in the queue ahead of you.

@travispotterBH
Copy link

Popup loading time is noticeably longer with the inclusion of this functionality. I suspect this is due to the need to load up the project data from the database. I suggest a form of caching, but am unsure how to implement this where it would meet both the requirements to have up-to-date project data and have shorter loading times.
#46

There appears to be a bug where typing speed above ~50wpm will cause the filter to reset while searching.
#45

It would be nice to have the projects separated by active/inactive/dormant status. Suggest that active projects appear in the standard filter background color, and inactive/dormant projects appear "greyed out" or indicated to be different in some way more readily apparent by choice of color/shading/indentation/etc.
#47

I think this is a nice feature addition and am prepared to approve this PR, provided that the items above are set as bug/feature request issues to addressed prior to the release of 6.0.

@FraserGreenroyd
Copy link
Author

@travispotterBH thanks for the review, I'm happy to pick up #45 and #46 in a new PR or 2, with #47 possibly being handled by what I'll do for #46. I think if we deploy this via alpha, we can start to get some user feedback as well while we then work on #45/#46 😄

Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that we've agreed to address issues as separate PRs

@FraserGreenroyd
Copy link
Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 28 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit e4bcae8 into main Oct 3, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoMAnalytics_Toolkit-#43-ProjectDatabaseLink branch October 3, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect analytics with project database
3 participants