-
Notifications
You must be signed in to change notification settings - Fork 1
Add link to project database for analytics #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add link to project database for analytics #44
Conversation
@BHoMBot check project-compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd fix requested for project compliance. The errors with the CSProject ( I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix project file ref. 8675863275 |
@FraserGreenroyd I have queued up your request to fix the |
@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made. |
@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request. |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd fix requested for copyright headers. The errors with the copyright headers on the CS ( I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check. Each CS ( If you are happy for me to go ahead and perform this action, please reply with:
|
@BHoMBot fix copyright headers ref. 8676040222 |
@FraserGreenroyd I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you. |
@FraserGreenroyd I am now going to fix the copyright compliance in accordance with the annotations previously made. |
@FraserGreenroyd to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request. |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 4 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 11 requests in the queue ahead of you. |
Popup loading time is noticeably longer with the inclusion of this functionality. I suspect this is due to the need to load up the project data from the database. I suggest a form of caching, but am unsure how to implement this where it would meet both the requirements to have up-to-date project data and have shorter loading times. There appears to be a bug where typing speed above ~50wpm will cause the filter to reset while searching. It would be nice to have the projects separated by active/inactive/dormant status. Suggest that active projects appear in the standard filter background color, and inactive/dormant projects appear "greyed out" or indicated to be different in some way more readily apparent by choice of color/shading/indentation/etc. I think this is a nice feature addition and am prepared to approve this PR, provided that the items above are set as bug/feature request issues to addressed prior to the release of 6.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the basis that we've agreed to address issues as separate PRs
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 28 requests in the queue ahead of you. |
Issues addressed by this PR
Fixes #43
Test files
N/A
Steps to test:
0000000
project ID if you wish to test the confirm optionSecond test:
Changelog
Additional comments