Skip to content

Add support for analytics of websites #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 26, 2022

Conversation

adecler
Copy link
Member

@adecler adecler commented Oct 8, 2021

@adecler adecler added the type:feature New capability or enhancement label Oct 8, 2021
@adecler adecler requested a review from al-fisher October 8, 2021 03:14
@adecler adecler self-assigned this Oct 8, 2021
@adecler
Copy link
Member Author

adecler commented Nov 23, 2021

@BHoMBot check project-compliance
@BHoMBot check documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

@adecler to confirm, the following checks are now queued:

  • project-compliance
  • documentation-compliance

@adecler
Copy link
Member Author

adecler commented Nov 23, 2021

@BHoMBot check project-compliance
@BHoMBot check documentation-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

@adecler to confirm, the following checks are now queued:

  • project-compliance
  • documentation-compliance

@adecler
Copy link
Member Author

adecler commented Nov 23, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

@adecler to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@adecler
Copy link
Member Author

adecler commented Nov 23, 2021

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

@adecler to confirm, the following checks are now queued:

  • core

@adecler
Copy link
Member Author

adecler commented Nov 23, 2021

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

@adecler to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2021

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@adecler adecler force-pushed the BHoMAnalytics_Toolkit-#25-WebAnalytics branch from fc9a3d0 to 38baa3b Compare January 19, 2022 02:16
@adecler
Copy link
Member Author

adecler commented Jan 19, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

@adecler to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

@adecler fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 4862460326

@adecler
Copy link
Member Author

adecler commented Jan 19, 2022

@BHoMBot fix copyright headers ref. 4862460326

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

@adecler I am now going to fix the copyright compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

@adecler to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

@adecler
Copy link
Member Author

adecler commented Jan 19, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

@adecler to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

@adecler
Copy link
Member Author

adecler commented Jan 19, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

@adecler to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@adecler
Copy link
Member Author

adecler commented Jan 19, 2022

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

@adecler to confirm, the following checks are now queued:

  • core

There are 8 requests in the queue ahead of you.

@adecler
Copy link
Member Author

adecler commented Jan 19, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

@adecler to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@adecler
Copy link
Member Author

adecler commented Jan 19, 2022

@al-fisher , it would be great to get this merged alongside the PR for the BuildingPerformance website.
FYI, I have checked that the database is still receiving the data and all seems to be working.

@adecler
Copy link
Member Author

adecler commented Jan 19, 2022

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 19, 2022

@adecler to confirm, the following checks are now queued:

  • copyright-compliance

There are 31 requests in the queue ahead of you.

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with these changes, brings in the analytics for web usage and is being seen on the databases as remarked by @adecler so would have no qualms with this being merged in.

@adecler adecler merged commit b8e9670 into main Jan 26, 2022
@adecler adecler deleted the BHoMAnalytics_Toolkit-#25-WebAnalytics branch January 26, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for analytics of websites
3 participants