Skip to content

Add AGS_Toolkit to Alpha Installer #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

peterjamesnugent
Copy link
Member

@peterjamesnugent peterjamesnugent commented Aug 7, 2024

Issues addressed by this PR

Closes #17

Test files

Changelog

Additional comments

@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Aug 7, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.3 β MVP milestone Aug 7, 2024
@peterjamesnugent peterjamesnugent self-assigned this Aug 7, 2024
@peterjamesnugent
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Aug 7, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@peterjamesnugent
Copy link
Member Author

@BHoMBot check installer

Copy link

bhombot-ci bot commented Aug 7, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

Copy link

bhombot-ci bot commented Aug 7, 2024

This repository is not part of the installer package, and does not require an installer check.

Copy link

bhombot-ci bot commented Aug 7, 2024

@peterjamesnugent just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on BHoM_Installer

@adecler
Copy link
Member

adecler commented Aug 8, 2024

@BHoMBot check serialisation
@BHoMBot check null-handling
@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Aug 8, 2024

@adecler to confirm, the following actions are now queued:

  • check serialisation
  • check null-handling
  • check ready-to-merge

There are 2 requests in the queue ahead of you.

@adecler
Copy link
Member

adecler commented Aug 8, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 8, 2024

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 2 requests in the queue ahead of you.

Copy link
Contributor

@michaelhoehn michaelhoehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve! Branch protection CI updates have been applied as well.

@adecler adecler merged commit 0f01b22 into develop Aug 8, 2024
11 checks passed
@adecler adecler deleted the AGS_Toolkit-#17-AddToInstaller branch August 8, 2024 16:00
Copy link

bhombot-ci bot commented Aug 9, 2024

This repository is not part of the beta package and does not require a versioning check to be performed.

Copy link

bhombot-ci bot commented Aug 9, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AGS_Toolkit in to the Alpha
3 participants