-
Notifications
You must be signed in to change notification settings - Fork 234
Update to .NET 9 GA. Update some test dependencies. #3134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
32abdb7
Update to .NET 9 GA. Update some test dependencies.
pmaytak 2dc10a0
Merge remote-tracking branch 'origin/master' into pmaytak/net9
pmaytak e6b0e7a
Don't install extra SDKs.
pmaytak 533e6a5
Add TargetNetNext flag.
pmaytak fd590e6
Merge branch 'master' into pmaytak/net9
jennyf19 aca9b39
Merge origin/main.
pmaytak c17c8e4
Revert framework order.
pmaytak bfe0ebe
Fix GitHub Actions.
pmaytak 08d803f
Update aot-check.yml
pmaytak 7f67603
Rever use SDK tasks.
pmaytak 88be0e2
Update aot-check.
pmaytak 49fb8bd
Revert.
pmaytak d269e38
Nit updates.
pmaytak e0320c2
Update AOT test.
pmaytak b8b96c6
Reorder tests.
pmaytak bb79562
Revert reorder. Add VS version to MS build.
pmaytak e979fe1
Merge remote-tracking branch 'origin/master' into pmaytak/net9
pmaytak 5a99fb7
Remove vs version.
pmaytak 7b8f12f
Update.
pmaytak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,6 +22,11 @@ jobs: | |
with: | ||
fetch-depth: 1 | ||
|
||
- name: Setup .NET 9.0.x | ||
uses: actions/[email protected] | ||
with: | ||
dotnet-version: 9.0.x | ||
|
||
- name: Runs powershell script | ||
id: aot-powershell | ||
run: build\test-aot.ps1 'net8.0' | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,29 +20,14 @@ on: | |
jobs: | ||
build: | ||
runs-on: windows-latest | ||
continue-on-error: true | ||
continue-on-error: false | ||
name: "Build and run unit tests" | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/[email protected] | ||
|
||
- name: Setup .NET 6.0.x | ||
uses: actions/[email protected] | ||
with: | ||
dotnet-version: 6.0.x | ||
|
||
- name: Setup .NET 7.0.x | ||
uses: actions/[email protected] | ||
with: | ||
dotnet-version: 7.0.x | ||
|
||
- name: Setup .NET 8.0.x | ||
uses: actions/[email protected] | ||
with: | ||
dotnet-version: 8.0.x | ||
|
||
- name: Setup .NET 9.0.x | ||
uses: actions/setup-dotnet@v4.0.1 | ||
uses: actions/setup-dotnet@v4.1.0 | ||
with: | ||
dotnet-version: 9.0.x | ||
|
||
|
@@ -64,22 +49,22 @@ jobs: | |
run: dotnet test --no-restore --no-build Microsoft.Identity.Web.sln -f net8.0 -v normal -p:FROM_GITHUB_ACTION=true --configuration Release --collect "Xplat Code Coverage" --filter "(FullyQualifiedName!~Microsoft.Identity.Web.Test.Integration)&(FullyQualifiedName!~WebAppUiTests)&(FullyQualifiedName!~IntegrationTests)&(FullyQualifiedName!~TokenAcquirerTests)" | ||
|
||
- name: Test with .NET 9.0.x | ||
run: dotnet test --no-restore --no-build Microsoft.Identity.Web.sln -f net9.0 -v normal -p:FROM_GITHUB_ACTION=true --configuration Release --collect "Xplat Code Coverage" --filter "(FullyQualifiedName!~Microsoft.Identity.Web.Test.Integration)&(FullyQualifiedName!~WebAppUiTests)&(FullyQualifiedName!~IntegrationTests)&(FullyQualifiedName!~TokenAcquirerTests)" | ||
run: dotnet test Microsoft.Identity.Web.sln -f net9.0 -v normal -p:FROM_GITHUB_ACTION=true --configuration Release --collect "Xplat Code Coverage" --filter "(FullyQualifiedName!~Microsoft.Identity.Web.Test.Integration)&(FullyQualifiedName!~WebAppUiTests)&(FullyQualifiedName!~IntegrationTests)&(FullyQualifiedName!~TokenAcquirerTests)" | ||
|
||
- name: Create code coverage report | ||
run: | | ||
dotnet tool install -g dotnet-reportgenerator-globaltool | ||
dotnet tool install -g dotnet-reportgenerator-globaltool --version 5.4.1 | ||
reportgenerator -reports:./**/coverage.cobertura.xml -targetdir:CodeCoverage -reporttypes:'MarkdownSummaryGithub;Cobertura' | ||
|
||
- name: Write Coverage to Job Summary | ||
- name: Write coverage to job summary | ||
shell: bash | ||
run: | | ||
cat CodeCoverage/SummaryGithub.md >> $GITHUB_STEP_SUMMARY | ||
echo "COMMENT_CONTENT_ENV_VAR<<EOF" >> $GITHUB_ENV | ||
echo $(cat CodeCoverage/SummaryGithub.md) >> $GITHUB_ENV | ||
echo "EOF" >> $GITHUB_ENV | ||
|
||
- name: Comment Coverage in PR | ||
- name: Comment coverage in PR | ||
uses: actions/github-script@v7 | ||
id: comment | ||
with: | ||
|
@@ -91,9 +76,6 @@ jobs: | |
body: process.env.COMMENT_CONTENT_ENV_VAR | ||
}) | ||
|
||
- name: Test with .NET 9.0.x | ||
run: dotnet test --no-restore --no-build Microsoft.Identity.Web.sln -f net9.0 -v normal -p:FROM_GITHUB_ACTION=true -p:TargetNet9=True --configuration Release --filter "(FullyQualifiedName!~Microsoft.Identity.Web.Test.Integration)&(FullyQualifiedName!~WebAppUiTests)&(FullyQualifiedName!~IntegrationTests)&(FullyQualifiedName!~TokenAcquirerTests)" | ||
|
||
- name: Test with .NET 462 | ||
run: dotnet test --no-restore --no-build Microsoft.Identity.Web.sln -f net462 -v normal -p:FROM_GITHUB_ACTION=true --configuration Release --filter "(FullyQualifiedName!~Microsoft.Identity.Web.Test.Integration)&(FullyQualifiedName!~WebAppUiTests)&(FullyQualifiedName!~IntegrationTests)" | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
src/Microsoft.Identity.Web.UI/Microsoft.Identity.Web.UI.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
tests/E2E Tests/IntegrationTestService/IntegrationTestService.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
tests/Microsoft.Identity.Web.Test.Common/Microsoft.Identity.Web.Test.Common.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
tests/Microsoft.Identity.Web.Test.Integration/Microsoft.Identity.Web.Test.Integration.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 3 additions & 3 deletions
6
...eTests/Microsoft.Identity.Web.Perf.Benchmark/Microsoft.Identity.Web.Perf.Benchmark.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.