Skip to content

Update changelog.md #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Update changelog.md #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
7.2.1
========
## Bug fix:
- `Id` property in `CredentialDescription` was derived from secret values, primarily affecting logging (information level) of credential attempts in `Microsoft.Identity.Web`, it doesn't affect higher log levels because if the failure occurs, it indicates that a credential description has both a credential source that can fail (e.g., certificate) and the `ClientSecret` property set, which is not a typical scenario. See issue [#147](https://github.com/AzureAD/microsoft-identity-abstractions-for-dotnet/pull/142) for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jennyf19 Wrong issue linked.

Suggested change
- `Id` property in `CredentialDescription` was derived from secret values, primarily affecting logging (information level) of credential attempts in `Microsoft.Identity.Web`, it doesn't affect higher log levels because if the failure occurs, it indicates that a credential description has both a credential source that can fail (e.g., certificate) and the `ClientSecret` property set, which is not a typical scenario. See issue [#147](https://github.com/AzureAD/microsoft-identity-abstractions-for-dotnet/pull/142) for details.
- `Id` property in `CredentialDescription` was derived from secret values, primarily affecting logging (information level) of credential attempts in `Microsoft.Identity.Web`, it doesn't affect higher log levels because if the failure occurs, it indicates that a credential description has both a credential source that can fail (e.g., certificate) and the `ClientSecret` property set, which is not a typical scenario. See issue [#147](https://github.com/AzureAD/microsoft-identity-abstractions-for-dotnet/pull/147) for details.


7.2.0
========
## New features:
Expand Down
Loading