Fix cache not being used when scopes are empty in acquireTokenSilent #7904
+29,086
−35,248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
acquireTokenSilent
is called with empty scopes (scopes: []
), the cache lookup fails with a configuration error, causing unnecessary network requests to Azure AD instead of using cached tokens.Root Cause
The
ScopeSet
constructor throws an error for empty scope arrays inScopeSet.createSearchScopes()
, preventing cache lookup from occurring inCacheManager.getAccessToken()
. This causes the silent flow to fall back to network requests even when valid cached tokens exist.Solution
Modified
ScopeSet.createSearchScopes()
to handle empty scopes gracefully by defaulting to OIDC default scopes (openid
,profile
,offline_access
) for cache lookups. The method now:offline_access
for OIDC-only scope sets)Changes Made
ScopeSet.createSearchScopes()
: Added logic to default to OIDC scopes when input is emptyBehavior
ClientConfigurationError
→ Network request["openid", "profile"]
→ Cache hit if available → Network fallback if neededBenefits
This surgical fix resolves the issue while maintaining all existing behaviors and security boundaries.
Fixes #6969.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.