-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Added token revocation functionality to Managed Identity's App Service source #7772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Robbie-Microsoft
wants to merge
43
commits into
dev
Choose a base branch
from
app_service_token_revocation
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
920bac3
Initial Implementation
Robbie-Microsoft 73ffd22
Change files
Robbie-Microsoft f4f002a
Improvements
Robbie-Microsoft 468de01
Improvements
Robbie-Microsoft dcd382f
Added unit tests
Robbie-Microsoft d8fbbca
Merge branch 'dev' into msi_v1_token_revocation
Robbie-Microsoft b09a464
Implemented some github feedback
Robbie-Microsoft 0f7b2b9
Implemented github feedback
Robbie-Microsoft b32f45e
package-lock
Robbie-Microsoft 604194d
Defined sha256 hash for test access token
Robbie-Microsoft 3405bce
Switched to hex encoding, instead of base64, for the sha256 hash
Robbie-Microsoft f1d096f
Change files
Robbie-Microsoft 203d5d0
Merge branch 'dev' into msi_v1_token_revocation
Robbie-Microsoft d9f15e6
Merge branch 'dev' into msi_v1_token_revocation
Robbie-Microsoft 0832c02
Merge branch 'dev' into msi_v1_token_revocation
Robbie-Microsoft 753ec2b
Merge branch 'dev' into msi_v1_token_revocation
Robbie-Microsoft aa2a42d
Merge branch 'dev' into msi_v1_token_revocation
Robbie-Microsoft 0f15894
Merge branch 'dev' into msi_v1_token_revocation
Robbie-Microsoft b48caf9
Implemented Neha's feedback
Robbie-Microsoft 865697d
Merge branch 'dev' into msi_v1_token_revocation
Robbie-Microsoft 2295235
Removed app service
Robbie-Microsoft 3990385
added token revocation to app service
Robbie-Microsoft c34e1e4
undid code deletion
Robbie-Microsoft 99cf38e
Merge branch 'msi_v1_token_revocation' into app_service_token_revocation
Robbie-Microsoft f9b13fb
Added back happy path test
Robbie-Microsoft 9f1f862
Merge branch 'msi_v1_token_revocation' into app_service_token_revocation
Robbie-Microsoft e7e0af7
added additional unit test
Robbie-Microsoft 4a59853
typos
Robbie-Microsoft a3434fa
Merge branch 'dev' into msi_v1_token_revocation
Robbie-Microsoft bdc6841
Merge branch 'msi_v1_token_revocation' into app_service_token_revocation
Robbie-Microsoft 77c94d0
fixed incorrect comment
Robbie-Microsoft b29be2f
Merge branch 'dev' into msi_v1_token_revocation
Robbie-Microsoft 4bd2045
Merge branch 'msi_v1_token_revocation' into app_service_token_revocation
Robbie-Microsoft 56c1103
Improved unit test
Robbie-Microsoft 656bbe3
Change files
Robbie-Microsoft 5bab9ed
Merge branch 'dev' into app_service_token_revocation
Robbie-Microsoft 760e7b7
Merge branch 'dev' into app_service_token_revocation
Robbie-Microsoft fe1a1ca
Merge branch 'dev' into app_service_token_revocation
Robbie-Microsoft 73ea7a8
Merge branch 'dev' into app_service_token_revocation
Robbie-Microsoft c635d40
Merge branch 'dev' into app_service_token_revocation
Robbie-Microsoft 58fb4a3
Merge branch 'dev' into app_service_token_revocation
Robbie-Microsoft 2fda006
Merge branch 'dev' into app_service_token_revocation
Robbie-Microsoft 599c576
Merge branch 'dev' into app_service_token_revocation
Robbie-Microsoft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
change/@azure-msal-node-cb198692-a92c-4591-96a7-77bb2383a356.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "minor", | ||
"comment": "Added token revocation functionality to Managed Identity's App Service source #7772", | ||
"packageName": "@azure/msal-node", | ||
"email": "[email protected]", | ||
"dependentChangeType": "patch" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't merge this until you get green light from @gladjohn , who is in contact with App Service.