Instrument correlation between silent and interactive requests #7146
Conversation
konstantin-msft
commented
Jun 5, 2024
konstantin-msft
commented
- Instrument correlation between silent and interactive requests
github-actions
bot
added
msal-browser
| // Warning: (tsdoc-undefined-tag) The TSDoc tag "@return" is not defined in this configuration | ||
| generateRequestThumbprint(request: SilentRequest | SsoSilentRequest | PopupRequest | RedirectRequest): string; | ||
| // Warning: (tsdoc-param-tag-missing-hyphen) The @param block should be followed by a parameter name and then a hyphen | ||
| // Warning: (tsdoc-param-tag-with-invalid-type) The @param block should not include a JSDoc-style '{type}' |
konstantin-msft
force-pushed
the
telemetry_correlate_silent_and_interactive_calls
branch
from
47299f2 to
2671e45
Compare
* Serializes thumbprint map entries when redirect begins * Rehydrates thumbprint map when returning from redirect * Adds embeddedClientId to perf thumbprint when available
| * @return string | ||
| */ | ||
| getThumbprintMapSerialized(): string { | ||
| const toArray = (map : any) : any => |
There was a problem hiding this comment.
You can probably simplify this with const stringifiedThumbprints = JSON.stringify(Array.from(this.thumbprints.entries()))
| @@ -93,6 +93,7 @@ export const TemporaryCacheKeys = { | |||
| CORRELATION_ID: "request.correlationId", | |||
| NATIVE_REQUEST: "request.native", | |||
| REDIRECT_CONTEXT: "request.redirect.context", | |||
| THUMBPRINTS: "thumbprints", | |||
There was a problem hiding this comment.
THUMBPRINTS: "thumbprints", -> THUMBPRINTS: "request.telemetry.thumbprints",
| PerformanceEvents.AcquireTokenRedirect, | ||
| PerformanceEvents.AcquireTokenPopup, | ||
| ] | ||
| PerformanceEvents.AcquireTokenSilent.toString(), |
There was a problem hiding this comment.
You can use event.name in Object.values([PerformanceEvents.AcquireTokenSilent, ...]) to avoid converting each entry to string
| ] | ||
| PerformanceEvents.AcquireTokenSilent.toString(), | ||
| PerformanceEvents.SsoSilent.toString(), | ||
| ].includes(event.name) |
| ] | ||
| PerformanceEvents.AcquireTokenSilent.toString(), | ||
| PerformanceEvents.SsoSilent.toString(), | ||
| ].includes(event.name) |
| @@ -500,6 +511,13 @@ export class RedirectClient extends StandardInteractionClient { | |||
| ); | |||
| } | |||
|
|
|||
| // Not sure if this is the right place for this logic to live | |||
| // Read thumbprints from temporary cache if PerformanceClient is not 3P | |||
There was a problem hiding this comment.
Read thumbprints from temporary cache if PerformanceClient is not 3P -> Read thumbprints from temporary cache if PerformanceClient is instance of BrowserPerformanceClient. Please remove this comment as code below is pretty clear
| @@ -114,6 +115,16 @@ export class RedirectClient extends StandardInteractionClient { | |||
| validRequest.loginHint || "", | |||
| validRequest.account || null | |||
| ); | |||
|
|
|||
| // Cache thumbprints for telemetry linking if PerformanceClient is not 3P | |||
There was a problem hiding this comment.
Read thumbprints from temporary cache if PerformanceClient is not 3P -> Read thumbprints from temporary cache if PerformanceClient is instance of BrowserPerformanceClient. Please remove this comment as code below is pretty clear
| @@ -1337,6 +1345,15 @@ export class BrowserCacheManager extends CacheManager { | |||
| return parsedRequest; | |||
| } | |||
|
|
|||
| getCachedThumbprints(): string { | |||
| const cachedThumbprintsSerialized = this.getTemporaryCache( | |||
There was a problem hiding this comment.
Can be simplified with
return this.getTemporaryCache(...) || ""
