Add classname to silent token renewal iframe HTML Element #6960
Conversation
lalimasharda
requested review from
hectormmg,
tnorling,
peterzenz,
sameerag,
jo-arroyo,
bgavrilMS,
Robbie-Microsoft,
trwalke,
pmaytak,
gladjohn,
rayluo,
Avery-Dunn and
konstantin-msft
as code owners
github-actions
bot
added
documentation
github-actions
bot
removed
documentation
github-actions
bot
removed
the
extensions
| const authFrame = document.createElement("iframe"); | ||
|
|
||
| authFrame.className = "silentTokenRenewalIframe"; | ||
| authFrame.src = urlNavigate; |
There was a problem hiding this comment.
Is there a reason why we did not do this before? @tnorling any browser policy issues we need to worry about?
There was a problem hiding this comment.
There was a limitation in some older browsers, namely IE11, that affected iframe creation. To workaround we allowed applications to configure whether the src attribute should be assigned synchronously or asynchronously - we can likely remove that configuration in v4 but we'll need to keep the existing model in v3 to avoid a change in behavior here
There was a problem hiding this comment.
Noted, thanks!
There was a problem hiding this comment.
That is what I was wondering. @lalimasharda let us stick to className for now to unblock Dime.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
*This pull request uses carry forward flags. Click here to find out more.
|
|
|
||
| setTimeout(() => { | ||
| if (!frameHandle) { | ||
| reject("Unable to load iframe"); | ||
| return; | ||
| } | ||
|
|
||
| frameHandle.src = urlNavigate; |
There was a problem hiding this comment.
This is a breaking change and needs to wait for v4 - can you file a work item if one doesn't exist?
| const authFrame = document.createElement("iframe"); | ||
|
|
||
| authFrame.className = "silentTokenRenewalIframe"; |
There was a problem hiding this comment.
Curious why this is needed?
There was a problem hiding this comment.
Bing is blocking Dime ssoSilent on 2.x (pre-broker). They want a classname to get an exception.
There was a problem hiding this comment.
I see...interesting. Should we include "msal" in the name somewhere?
There was a problem hiding this comment.
Not a bad idea, @lalimasharda can we do that, say msalSilentIframe
lalimasharda
changed the title
Porting change from v2 PR: #6960
No description provided.