Nested App Auth: allow empty parameters for loginPopup #6941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codexeon
requested review from
sameerag,
tnorling,
hectormmg,
jo-arroyo,
peterzenz and
konstantin-msft
as code owners
sameerag
reviewed
Mar 11, 2024
sameerag
reviewed
Mar 11, 2024
sameerag
approved these changes
Mar 21, 2024
codexeon
force-pushed
the
dasau/naa_defaultloginpopup
branch
from
ea20001 to
eebc749
Compare
codexeon
force-pushed
the
dasau/naa_defaultloginpopup
branch
3 times, most recently
from
a8afa73 to
54203c9
Compare
codexeon
force-pushed
the
dasau/naa_defaultloginpopup
branch
2 times, most recently
from
8864789 to
cfe3a85
Compare
codexeon
force-pushed
the
dasau/naa_defaultloginpopup
branch
from
cfe3a85 to
2e479b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows empty parameters for loginPopup by using a default request to match the behavior of StandardController. It also removes the dependency on crypto.randomUUID() which is not used elsewhere in the MSAL code base. Use the shared implementation to generate UUID v7 instead.