fix: support both login.partner.microsoftonline.cn and login.chinaclo… #575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXES #574
here problem(#574 ) is when we upgrad the azure thing and the ms auth thing for go, it break in china cloud. it not login good anymore. new lib only like login.partner.microsoftonline.cn but lot of old stuffs still use login.chinacloudapi.cn. so it not work and the cloud thingy not start.
i make this pr to fix it. now we say okay to both old and new login link in the aadTrustedHostList.
so now both new and old can login. no more break. i also write small note in code so we remember to check this again later maybe.
this help people move slowly to new thing without everything go boom. it only fix china cloud. other clouds is okay.
this fix the bug where login.partner.microsoftonline.cn no work in china cloud. it also related to the azure provider and the ms login thing change.