Skip to content

fix: support both login.partner.microsoftonline.cn and login.chinaclo… #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Achiket123
Copy link

@Achiket123 Achiket123 commented Jul 5, 2025

FIXES #574
here problem(#574 ) is when we upgrad the azure thing and the ms auth thing for go, it break in china cloud. it not login good anymore. new lib only like login.partner.microsoftonline.cn but lot of old stuffs still use login.chinacloudapi.cn. so it not work and the cloud thingy not start.

i make this pr to fix it. now we say okay to both old and new login link in the aadTrustedHostList.

  • add login.partner.microsoftonline.cn (new one)
  • keep login.chinacloudapi.cn (old one lots people still use)

so now both new and old can login. no more break. i also write small note in code so we remember to check this again later maybe.

this help people move slowly to new thing without everything go boom. it only fix china cloud. other clouds is okay.

this fix the bug where login.partner.microsoftonline.cn no work in china cloud. it also related to the azure provider and the ms login thing change.

…udapi.cn for China cloud (backward compatibility)
Copy link

sonarqubecloud bot commented Jul 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] login.partner.microsoftonline.cn does not work for China cloud
1 participant