-
Notifications
You must be signed in to change notification settings - Fork 98
Added support for Token revocation support #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of the Go content. Someone from the MSAL side should review the doc content
@@ -82,7 +84,7 @@ const ( | |||
tokenName = "Tokens" | |||
|
|||
// App Service | |||
appServiceAPIVersion = "2019-08-01" | |||
appServiceAPIVersion = "2025-03-30" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good and matches the app service new version. We just want to make sure not to merge this PR yet, as App Service rollout is still happening.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does it work in MSAL .net about guarding the release or the version blocking ?
@4gust this looks good, did not approve it because of the app service api-version update. anyway we can guard it? |
|
PR Title: Add Token Revocation Handling and Enhanced Testing for App Service in Managed Identity
Description:
This PR introduces a new feature to handle token revocation scenarios in App Service managed identity and enhances testing to ensure robust behavior. The changes focus on handling claims challenges, bad access tokens from the cache, and validating client capabilities.
Changes:
Feature Implementation:
Token Revocation Handling:
claims
parameter included in the URL to obtain a fresh token.Bad Access Token Handling:
New Unit Tests:
TestAppServiceWithClaimsAndBadAccessToken
TestAppServiceWithClientCapabilities
client_capabilities
parameter is correctly passed and processed.