Use Broker Content Provider for number match, Fixes AB#3308440 #2699

siddhijain · 2025-07-01T15:05:51Z

AB#3308440
This PR adds constants used by AADAuthenticator module for number match scenarios.

github-actions · 2025-07-01T15:06:03Z

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

Copilot

Pull Request Overview

This PR introduces a Content Provider for number match storage and updates related modules and tests accordingly.

Updated NumberMatchHelper to use a Content Provider instead of a static HashMap.
Modified tests and Auth UX interfaces to work with the new storage mechanism.
Added broker operation and constants for number match retrieval.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
common/src/test/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchHelperTest.kt	Updated tests to validate the new Content Provider-based storage for number match data.
common/src/test/java/com/microsoft/identity/common/internal/broker/AuthUxJavaScriptInterfaceTest.kt	Modified test setup to include context injection for the updated Auth UX JavaScript interface.
common/src/main/java/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java	Updated to pass the application context when attaching the Auth UX JavaScript interface.
common/src/main/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchHelper.kt	Replaced static map usage with Content Provider interactions for storing and retrieving number match values.
common/src/main/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchDbHelper.kt	New SQLiteOpenHelper implementation to support the number match Content Provider.
common/src/main/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchContentProvider.kt	New Content Provider implementation managing number match data persistence.
common/src/main/java/com/microsoft/identity/common/internal/broker/ipc/BrokerOperationBundle.java	Added new broker operation for retrieving number match information.
common/src/main/java/com/microsoft/identity/common/internal/broker/AuthUxJavaScriptInterface.kt	Modified the constructor to require a context and updated the number match storage call accordingly.
common/src/main/java/com/microsoft/identity/common/adal/internal/AuthenticationConstants.java	Added new constants for the number match result and API path.

...c/main/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchContentProvider.kt

github-actions · 2025-07-01T16:30:36Z

✅ Work item link check complete. Description contains link AB#3308440 to an Azure Boards work item.

common/src/main/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchHelper.kt

shahzaibj · 2025-07-01T18:49:24Z

common/src/main/java/com/microsoft/identity/common/internal/broker/AuthUxJavaScriptInterface.kt

@@ -127,6 +130,9 @@ class AuthUxJavaScriptInterface {
            }

            val operation = parameters.operation
+            if (operation != null) {


In what cases would this be null?

I will let @fadidurah answer since it is a part of his changes.

As part of the AuthUx platform agnostic JS API discussion, operation is not a mandatory field at this time, future usages of this interface may not have this field, and may only rely on action_name and action_component

fadidurah

LGTM

mohitc1 · 2025-07-01T21:04:43Z

    fun clearNumberMatchMap() {

When is this called?

Refers to: common/src/main/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchHelper.kt:75 in 4d1f92f. [](commit_id = 4d1f92f, deletion_comment = False)

mohitc1

#2699)" This reverts commit c9ce6fb.

[AB#3308440](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3308440) This PR adds constants used by AADAuthenticator module for number match scenarios. --------- Co-authored-by: fadidurah <[email protected]>

fadidurah and others added 3 commits June 27, 2025 02:48

add telemetry for Auth Ux Javascript and Number Match

7a1743b

Use ContentProvider instead of hashmap for numberMatch data

43ccc58

Number match constants

d1951f7

Copilot AI review requested due to automatic review settings July 1, 2025 15:05

siddhijain requested a review from a team as a code owner July 1, 2025 15:05

Copilot AI reviewed Jul 1, 2025

View reviewed changes

...c/main/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchContentProvider.kt Outdated Show resolved Hide resolved

siddhijain added 2 commits July 1, 2025 10:16

Reverting unintentional changes

ce98c32

Updated documentation + remove unused import

9563fe3

github-actions bot changed the title ~~Use Broker Content Provider for number match~~ Use Broker Content Provider for number match, Fixes AB#3308440 Jul 1, 2025

fixed failing build

2dc874f

siddhijain added the No-Changelog This Pull-Request has no associated changelog entry. label Jul 1, 2025

revert old changes

14ef87c

fadidurah reviewed Jul 1, 2025

View reviewed changes

common/src/main/java/com/microsoft/identity/common/internal/numberMatch/NumberMatchHelper.kt Show resolved Hide resolved

fadidurah added 2 commits July 1, 2025 14:01

pull telem changes

d9b9cc3

pull telem changes

0ebb974

shahzaibj reviewed Jul 1, 2025

View reviewed changes

Adding 1 more constant to be consumed by AADAuthenticator

4d1f92f

fadidurah approved these changes Jul 1, 2025

View reviewed changes

Merge branch 'dev' into sjain/number-match-uses-broker-content-provider

f2cee0d

siddhijain added the Skip-Consumers-Check Only include this if making a breaking change purposefully, and there is an MSAL/ADAL/Broker PR label Jul 1, 2025

mohitc1 approved these changes Jul 1, 2025

View reviewed changes

siddhijain merged commit c9ce6fb into dev Jul 1, 2025
27 of 28 checks passed

siddhijain added a commit that referenced this pull request Jul 1, 2025

Revert "Use Broker Content Provider for number match, Fixes AB#3308440 (

723b667

#2699)" This reverts commit c9ce6fb.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use Broker Content Provider for number match, Fixes AB#3308440 #2699

Use Broker Content Provider for number match, Fixes AB#3308440 #2699

Uh oh!

siddhijain commented Jul 1, 2025 •

edited by azure-boards bot

Loading

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

Uh oh!

shahzaibj Jul 1, 2025

Uh oh!

siddhijain Jul 1, 2025

Uh oh!

fadidurah Jul 1, 2025 •

edited

Loading

Uh oh!

fadidurah left a comment

Uh oh!

mohitc1 commented Jul 1, 2025

Uh oh!

mohitc1 left a comment

Uh oh!

Uh oh!

Uh oh!

Use Broker Content Provider for number match, Fixes AB#3308440 #2699

Use Broker Content Provider for number match, Fixes AB#3308440 #2699

Uh oh!

Conversation

siddhijain commented Jul 1, 2025 • edited by azure-boards bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

github-actions bot commented Jul 1, 2025

Uh oh!

Uh oh!

shahzaibj Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

siddhijain Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

fadidurah Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fadidurah left a comment

Choose a reason for hiding this comment

Uh oh!

mohitc1 commented Jul 1, 2025

Uh oh!

mohitc1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

siddhijain commented Jul 1, 2025 •

edited by azure-boards bot

Loading

fadidurah Jul 1, 2025 •

edited

Loading