-
Notifications
You must be signed in to change notification settings - Fork 38
Common changes for Resource Account #2684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces changes related to handling Resource Account scenarios by updating exception handling, adding new constants, and enhancing test coverage.
- Adds new tests in ExceptionAdapterTests for resource account and MFA exception handling.
- Introduces a new RESOURCE_ACCOUNT grant type in TokenRequest and a corresponding public API constant.
- Adds a flag to BrokerSilentTokenCommandParameters to distinguish resource account requests and updates ExceptionAdapter logic accordingly.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
common4j/src/test/com/microsoft/identity/common/java/controllers/ExceptionAdapterTests.java | Updated tests with static assertions and added cases for resource account handling. |
common4j/src/main/com/microsoft/identity/common/java/providers/oauth2/TokenRequest.java | Added new grant type constant RESOURCE_ACCOUNT. |
common4j/src/main/com/microsoft/identity/common/java/eststelemetry/PublicApiId.java | Introduced new constant for broker resource account API. |
common4j/src/main/com/microsoft/identity/common/java/controllers/ExceptionAdapter.java | Modified exception resolution logic to consider resource account and broker parameters. |
common4j/src/main/com/microsoft/identity/common/java/commands/parameters/BrokerSilentTokenCommandParameters.java | Added a new field to indicate resource account token requests. |
common4j/src/test/com/microsoft/identity/common/java/controllers/ExceptionAdapterTests.java
Outdated
Show resolved
Hide resolved
common4j/src/main/com/microsoft/identity/common/java/controllers/ExceptionAdapter.java
Outdated
Show resolved
Hide resolved
common4j/src/main/com/microsoft/identity/common/java/controllers/ExceptionAdapter.java
Outdated
Show resolved
Hide resolved
// THE SOFTWARE. | ||
package com.microsoft.identity.common.java.jwt | ||
|
||
object JwtKeyUseTypes { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: comment/ context on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me fix that in next common PR.
Refer PRs: