-
Notifications
You must be signed in to change notification settings - Fork 36
Fix APPLICATION_CANCELLED by handling back button press #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm still working on getting a good MSAL and OneAuth test pass using these Common changes, but I wanted to give folks a chance to look at the code. |
Codecov Report
@@ Coverage Diff @@
## dev #1725 +/- ##
=========================================
Coverage 15.62% 15.62%
Complexity 321 321
=========================================
Files 164 164
Lines 7097 7097
Branches 712 712
=========================================
Hits 1109 1109
Misses 5815 5815
Partials 173 173
Continue to review full report at Codecov.
|
...va/com/microsoft/identity/common/internal/providers/oauth2/WebViewAuthorizationFragment.java
Show resolved
Hide resolved
nit: Can you also add a link to any documentations on what changed between appCompat version 1.1.0 and 1.0.2 corresponding to the change in this PR, for future reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added few minor comments
...main/java/com/microsoft/identity/common/internal/providers/oauth2/AuthorizationActivity.java
Show resolved
Hide resolved
When this PR is ingested to MSAL/OneAuth, the |
Okay, I'm back from OOF so this is ready for merge now, when someone with permissions is available to do so. |
…cation-cancelled Fix APPLICATION_CANCELLED by handling back button press
AuthorizationActivity
no longer needs to directly handle back button presses, and it's all standard machinery.(Web)AuthorizationFragment
handle the press, and lifetime is tied to that of its view.This change also updates the required androidx appcompat version from 1.0.2 -> 1.1. I expect most end-user applications are actually using an even newer version of this package already, as even 1.1 was released in 2019.