Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Express dependency in package.json doesn't match syntax used in website-sample.js #78

Closed
iambmelt opened this issue Sep 8, 2015 · 1 comment
Assignees
Labels

Comments

@iambmelt
Copy link

iambmelt commented Sep 8, 2015

sample/package.json declares a dependency on Express v2 but sample/website-sample.js initializes express by calling express() which is Express v3 syntax.

To reproduce the issue:

  1. git clone <repo>
  2. cd sample
  3. npm install && node website-sample.js

Failing output:

.../sample/website-sample.js:32
var app = express();
          ^
TypeError: object is not a function
    at Object.<anonymous> (.../sample/website-sample.js:32:11)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Function.Module.runMain (module.js:501:10)
    at startup (node.js:129:16)
    at node.js:814:3
amishra-dev pushed a commit that referenced this issue Apr 25, 2016
This is a fix for issues #71, #78 , and #80
@jmckennon
Copy link

All current authentication work from Microsoft is delivered through the msal js library here There is plans to add a similar node.js wrapper to msal js, as can be seen on our roadmap here. adal js, and the adal-node wrapper, is still supported only for security fixes. We recommend moving to msal js for any advanced feature requests and bugfixes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants