Treat web view errors as a SERVER_INVALID_REQUEST AuthenticationException | Close#726 #861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correct error code
heidijinxujia
changed the title
heidijinxujia
changed the title
|
@weijjia @addev-ashish Please let me know your concerns on the ErrorCode should returned to the calling app when getting an error from server in the webview. Thanks! |
|
This fix is fairly big and need to collaborate with partners. This will be moved to next milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #726
Treat web view errors as AuthenticationException with error code SERVER_INVALID_REQUEST and return the detailed error description back to the caller.