Petterh/issue 726: Do not treat web view errors as "cancel" #1018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 27, 2017 13:40
Added input type to email address field in sample app
of pretending the user cancelled the flow Fixed some typos Reduced visibility of classes and methods A bit less trailing white space
# Conflicts: # adal/src/main/java/com/microsoft/aad/adal/PromptBehavior.java
# Conflicts: # adal/src/main/java/com/microsoft/aad/adal/AuthenticationDialog.java # adal/src/main/java/com/microsoft/aad/adal/Discovery.java # sample/src/main/res/layout/activity_main.xml
# Conflicts: # adal/src/main/java/com/microsoft/aad/adal/AuthenticationActivity.java # adal/src/main/java/com/microsoft/aad/adal/AuthenticationConstants.java # adal/src/main/java/com/microsoft/aad/adal/AuthenticationDialog.java # adal/src/main/java/com/microsoft/aad/adal/BasicWebViewClient.java
added 3 commits
January 14, 2019 14:12
…activedirectory-library-for-android into petterh/issue-726 # Conflicts: # adal/src/main/java/com/microsoft/aad/adal/AuthenticationDialog.java
|
@iambmelt Any chance of anyone reviewing this? It's been over a year since I created the PR, but the bug is still there. |
|
Hi @petterh -- thanks for updating your PR -- personally, I'd really like to see this merge but am heads-down on some other work before I can dedicate cycles to this. This item has recently moved up visibility-wise and will be prioritized in an upcoming planning meeting. |
added 2 commits
May 7, 2019 13:48
# Conflicts: # adal/build.gradle # common
# Conflicts: # adal/build.gradle
petterh
force-pushed
the
petterh/issue-726
branch
from
e2f71aa to
98c5930
Compare
added 3 commits
September 6, 2019 08:53
# Conflicts: # adal/src/androidTest/java/com/microsoft/aad/adal/BasicWebViewClientTests.java # adal/src/main/java/com/microsoft/aad/adal/AuthenticationActivity.java # adal/src/main/java/com/microsoft/aad/adal/BasicWebViewClient.java
|
@iambmelt @heidijinxujia Any chance of this ever getting in? It's been hanging for over 22 months now. |
iambmelt
requested review from
kreedula
and removed request for
heidijinxujia
|
@petterh Merged - thanks for the nudge :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue 726: Web view errors treated as cancel.
This change properly propagates server-side authentication errors to client instead of pretending the user cancelled the flow.
Other minor fixes include removal of trailing white space, fixing the occasional typo and protecting against a possible NRE in
Discovery.