-
Notifications
You must be signed in to change notification settings - Fork 431
Don't lose TimeZone kind when creating sync after #3213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9849dc2
to
50eacda
Compare
Not a way to meaningfully test this. FakeTimeProvider can set the timezone, but this only works for local time, not UTC. I did manual tests with changing the DateTime settings of the host computer and verified the fix works there. |
pmaytak
approved these changes
Apr 24, 2025
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
mdchennu
approved these changes
Apr 24, 2025
pmaytak
reviewed
Apr 24, 2025
src/Microsoft.IdentityModel.Protocols/Configuration/ConfigurationManager.cs
Show resolved
Hide resolved
SummarySummary
CoverageMicrosoft.IdentityModel.JsonWebTokens - 80.3%
|
This was referenced Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't lose Time Zone kind when creating sync after
Summary of the changes (Less than 80 chars)
Description
Don't convert from UTC DateTimeOffset to DateTime, need to specify the kind as UTC, this is done through UtcDateTime from DateTimeOffset
Fixes #3212