Fix ValidationParameters Inconsistencies #3173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmaytak
reviewed
Mar 15, 2025
| @@ -530,6 +531,7 @@ public TokenReplayValidationDelegate TokenReplayValidator | |||
| /// all available keys will be tried. | |||
| /// </summary> | |||
| /// <remarks>Default is false.</remarks> | |||
| [DefaultValue(true)] | |||
There was a problem hiding this comment.
This also needs to be set in the empty constructor.
JoshLozensky
previously approved these changes
Mar 18, 2025
sruke
reviewed
Mar 18, 2025
| @@ -530,6 +532,7 @@ public TokenReplayValidationDelegate TokenReplayValidator | |||
| /// all available keys will be tried. | |||
| /// </summary> | |||
| /// <remarks>Default is false.</remarks> | |||
There was a problem hiding this comment.
Please update the remarks to state that the default value is now true.
|
Few unit tests are failing that require investigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ValidationParameters Inconsistencies
Summary
This PR fixes inconsistencies in
ValidationParametersby ensuring properties are copied correctly fromTokenValidationParameters.Description
TryAllIssuerSigningKeysproperty was not being copied in theValidationParameters(ValidationParameters other)constructor.TryAllIssuerSigningKeys.TryAllIssuerSigningKeyswasfalseby default, whereas it wastruein the current model. This has been aligned accordingly.ValidateActorinValidationParametersfor consistency.Fixes #3131