sonic-utilities: WRED stats feature changes on sonic-utilities #2807

rpmarvell · 2023-04-24T21:01:16Z

What I did

CLI support for WRED and ECN statistics feature

How I did it

New script for wredstat CLI commands
portstat script updated to accomodate WRED port stats
counterpoll script updated to support wredport and wredqueue counters
CLi to script mapping changes
UT for the new script changes

How to verify it

sonic-utilities UT and Marvell DUT manual testing

Previous command output (if the output of a command-line utility has changed)

root@sonic-dut:~# show interfaces counters detailed Ethernet8
Packets Received 64 Octets..................... 0
Packets Received 65-127 Octets................. 2
Packets Received 128-255 Octets................ 0
Packets Received 256-511 Octets................ 0
Packets Received 512-1023 Octets............... 0
Packets Received 1024-1518 Octets.............. 0
Packets Received 1519-2047 Octets.............. 0
Packets Received 2048-4095 Octets.............. 0
Packets Received 4096-9216 Octets.............. 0
Packets Received 9217-16383 Octets............. 0

Total Packets Received Without Errors.......... 2
Unicast Packets Received....................... 0
Multicast Packets Received..................... 2
Broadcast Packets Received..................... 0

Jabbers Received............................... N/A
Fragments Received............................. N/A
Undersize Received............................. 0
Overruns Received.............................. 0

Packets Transmitted 64 Octets.................. 32,893
Packets Transmitted 65-127 Octets.............. 16,449
Packets Transmitted 128-255 Octets............. 3
Packets Transmitted 256-511 Octets............. 2,387
Packets Transmitted 512-1023 Octets............ 0
Packets Transmitted 1024-1518 Octets........... 0
Packets Transmitted 1519-2047 Octets........... 0
Packets Transmitted 2048-4095 Octets........... 0
Packets Transmitted 4096-9216 Octets........... 0
Packets Transmitted 9217-16383 Octets.......... 0

Total Packets Transmitted Successfully......... 51,732
Unicast Packets Transmitted.................... 0
Multicast Packets Transmitted.................. 18,840
Broadcast Packets Transmitted.................. 32,892
Time Since Counters Last Cleared............... None

New command output (if the output of a command-line utility has changed)

root@sonic-dut:~# show interfaces counters detailed Ethernet8
Packets Received 64 Octets..................... 0
Packets Received 65-127 Octets................. 2
Packets Received 128-255 Octets................ 0
Packets Received 256-511 Octets................ 0
Packets Received 512-1023 Octets............... 0
Packets Received 1024-1518 Octets.............. 0
Packets Received 1519-2047 Octets.............. 0
Packets Received 2048-4095 Octets.............. 0
Packets Received 4096-9216 Octets.............. 0
Packets Received 9217-16383 Octets............. 0

Total Packets Received Without Errors.......... 2
Unicast Packets Received....................... 0
Multicast Packets Received..................... 2
Broadcast Packets Received..................... 0

Jabbers Received............................... N/A
Fragments Received............................. N/A
Undersize Received............................. 0
Overruns Received.............................. 0

Packets Transmitted 64 Octets.................. 32,893
Packets Transmitted 65-127 Octets.............. 16,449
Packets Transmitted 128-255 Octets............. 3
Packets Transmitted 256-511 Octets............. 2,387
Packets Transmitted 512-1023 Octets............ 0
Packets Transmitted 1024-1518 Octets........... 0
Packets Transmitted 1519-2047 Octets........... 0
Packets Transmitted 2048-4095 Octets........... 0
Packets Transmitted 4096-9216 Octets........... 0
Packets Transmitted 9217-16383 Octets.......... 0

Total Packets Transmitted Successfully......... 51,732
Unicast Packets Transmitted.................... 0
Multicast Packets Transmitted.................. 18,840
Broadcast Packets Transmitted.................. 32,892
Time Since Counters Last Cleared............... None

WRED Green Dropped Packets..................... 1
WRED Yellow Dropped Packets.................... 3
WRED RED Dropped Packets....................... 10
WRED Total Dropped Packets..................... 14

scripts/wredstat

doc/Command-Reference.md

scripts/wredstat

scripts/portstat

scripts/wredstat

stephenxs

Two minor comments.
The rest LGTM.

scripts/portstat

doc/Command-Reference.md

maipbui · 2023-06-29T17:35:01Z

@rpmarvell Please merge latest master code to trigger Semgrep.

kperumalbfn · 2024-11-18T19:27:12Z

utilities_common/portstat.py

+        45: ['SAI_PORT_STAT_GREEN_WRED_DROPPED_PACKETS'],
+        46: ['SAI_PORT_STAT_YELLOW_WRED_DROPPED_PACKETS'],
+        47: ['SAI_PORT_STAT_RED_WRED_DROPPED_PACKETS'],
+        48: ['SAI_PORT_STAT_WRED_DROPPED_PACKETS']


How about SAI_PORT_STAT_ECN_MARKED_PACKETS?

SAI_PORT_STAT_ECN_MARKED_PACKETS is not part of the HLD.

kperumalbfn · 2024-11-18T19:28:03Z

utilities_common/portstat.py

@@ -91,7 +100,11 @@
        41: ['SAI_PORT_STAT_IP_IN_RECEIVES'],
        42: ['SAI_PORT_STAT_IF_IN_FEC_CORRECTABLE_FRAMES'],
        43: ['SAI_PORT_STAT_IF_IN_FEC_NOT_CORRECTABLE_FRAMES'],
-        44: ['SAI_PORT_STAT_IF_IN_FEC_SYMBOL_ERRORS']
+        44: ['SAI_PORT_STAT_IF_IN_FEC_SYMBOL_ERRORS'],


If WRED profile action is 'ecn_marking', does this port counter(SAI_PORT_STAT_GREEN_WRED_DROPPED_PACKETS) show ECN marked packets or this is used only for WRED drop?

ECN marked statistics will not be counted in SAI_PORT_STAT_GREEN_WRED_DROPPED_PACKETS. Per Queue ECN statistics is supported thru this Feature.

kperumalbfn · 2025-01-15T18:39:50Z

@rpmarvell Could you resolve the conflicts

* New script for wredstat CLI commands * portstat script updated to accomodate WRED port stats * counterpoll script updated to support wredport and wredqueue counters * CLi to script mapping changes * UT for the new script changes * CLI command reference document updated Signed-off-by: rpmarvell <[email protected]>

mssonicbld · 2025-01-17T11:15:28Z

/azp run

azure-pipelines · 2025-01-17T11:15:40Z

Azure Pipelines successfully started running 1 pipeline(s).

rpmarvell · 2025-01-17T16:09:28Z

Resolved the conflicts.

kperumalbfn · 2025-01-17T16:21:57Z

Thanks @rpmarvell . Any build or test breakage of this sonic-utilities PR without swss and sairedis changes? If not, we can merge this and have other PRs later.please confirm

rpmarvell · 2025-01-17T18:07:26Z

There should not be any SONiC build issue or UT issue if we merge it without the other branches.

vmittal-msft · 2025-01-22T17:33:46Z

@rpmarvell Please share queue command output as well.

rpmarvell · 2025-01-23T03:00:56Z

sonic-dut:~# show queue wredcounters Ethernet16
      Port    TxQ    WredDrp/pkts    WredDrp/bytes  EcnMarked/pkts EcnMarked/bytes
----------  -----  --------------  ---------------  -------------- ---------------
Ethernet16    UC0               0                0               0               0
Ethernet16    UC1               1              120               0               0
Ethernet16    UC2               0                0               0               0
Ethernet16    UC3               0                0               0               0
Ethernet16    UC4               0                0               0               0
Ethernet16    UC5               0                0               0               0
Ethernet16    UC6               0                0               0               0
Ethernet16    UC7               0                0               0               0

mssonicbld · 2025-02-21T19:58:58Z

Cherry-pick PR to msft-202412: Azure/sonic-utilities.msft#128

* New flex counter group for per-Queue WRED and ECN statistics * New flex counter group for per-Port WRED and ECN statistics Signed-off-by: [email protected]  **What I did** WRED and ECN statistics support **Why I did it** Implemented as per the HLD : https://github.com/sonic-net/SONiC/blob/master/doc/qos/ECN_and_WRED_statistics_HLD.md **How I verified it** Verfied it using Marvell DUT and SWSS unit tests. **Details if related** - Two new flex counters added for per-Queue and per-Port WRED ECN statistics. Build dependency on sonic-swss-common pull request : sonic-net/sonic-swss-common#777 Expected order of dependent pull-request to be committed : 1) sonic-swss common pull request : sonic-net/sonic-swss-common#777 2) sonic-yang-model pull requests : sonic-net/sonic-buildimage#14758 3) sonic-sairedis pull request : sonic-net/sonic-sairedis#1234 4) sonic-swss : pull request : sonic-net/sonic-swss#2750 5) sonic-utilities pull request : sonic-net/sonic-utilities#2807

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch 2 times, most recently from 67af42e to 6438dd6 Compare April 26, 2023 20:07

rpmarvell mentioned this pull request Apr 26, 2023

sonic-yang-models: WRED statistics yang sonic-net/sonic-buildimage#14758

Merged

10 tasks

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch 2 times, most recently from a22be8b to 8e814a4 Compare May 1, 2023 19:51

rpmarvell mentioned this pull request May 9, 2023

HLD for ECN and WRED statistics support in SONiC sonic-net/SONiC#1273

Merged

msosyak reviewed May 9, 2023

View reviewed changes

scripts/wredstat Outdated Show resolved Hide resolved

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch 2 times, most recently from 6084f23 to 88db720 Compare May 18, 2023 20:31

rpmarvell requested a review from msosyak May 18, 2023 21:04

stephenxs reviewed May 26, 2023

View reviewed changes

doc/Command-Reference.md Show resolved Hide resolved

scripts/wredstat Outdated Show resolved Hide resolved

scripts/portstat Outdated Show resolved Hide resolved

scripts/portstat Outdated Show resolved Hide resolved

scripts/wredstat Outdated Show resolved Hide resolved

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch 2 times, most recently from 4725812 to 2a2bd9f Compare May 29, 2023 13:15

rpmarvell requested a review from stephenxs May 29, 2023 13:20

stephenxs reviewed May 30, 2023

View reviewed changes

scripts/portstat Outdated Show resolved Hide resolved

doc/Command-Reference.md Outdated Show resolved Hide resolved

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch from 2a2bd9f to 29a097c Compare May 30, 2023 07:01

stephenxs approved these changes May 30, 2023

View reviewed changes

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch from 29a097c to 989748b Compare June 15, 2023 09:54

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch from 4247129 to eb034f9 Compare December 5, 2023 12:26

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch from eb034f9 to 17d9c65 Compare January 31, 2024 12:42

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch 4 times, most recently from 0fad42d to 9d38aa0 Compare February 14, 2024 09:06

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch 2 times, most recently from cd9018d to 45f3465 Compare February 15, 2024 06:03

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch from b207d75 to c37e76a Compare November 7, 2024 10:50

rpmarvell dismissed kperumalbfn’s stale review via c37e76a November 13, 2024 16:53

kperumalbfn reviewed Nov 18, 2024

View reviewed changes

kperumalbfn mentioned this pull request Jan 15, 2025

Add support to show ECN marked packets on "show queue counters" sonic-net/sonic-buildimage#21249

Open

vmittal-msft self-requested a review January 16, 2025 00:55

rpmarvell force-pushed the rpmarvell_wred_stats_sonic_utilities branch from c37e76a to 226a8eb Compare January 17, 2025 11:15

kperumalbfn approved these changes Jan 17, 2025

View reviewed changes

vmittal-msft approved these changes Jan 22, 2025

View reviewed changes

vmittal-msft added the Request for 202411 Branch label Jan 23, 2025

kperumalbfn merged commit 8f69d5a into sonic-net:master Feb 4, 2025
7 checks passed

kperumalbfn added Request for msft-202412 Branch and removed Request for 202411 Branch labels Feb 18, 2025

r12f added the Approved for msft-202412 Branch label Feb 21, 2025

mssonicbld mentioned this pull request Feb 21, 2025

[action] [PR:2807] sonic-utilities: WRED stats feature changes on sonic-utilities Azure/sonic-utilities.msft#128

Merged

mssonicbld added the Created PR to msft-202412 Branch label Feb 21, 2025

mssonicbld added Included in msft-202412 Branch and removed Created PR to msft-202412 Branch labels Feb 21, 2025

mssonicbld mentioned this pull request Feb 28, 2025

[action] [PR:2750] sonic-swss: Code changes for WRED and ECN statistics Azure/sonic-swss.msft#46

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sonic-utilities: WRED stats feature changes on sonic-utilities #2807

sonic-utilities: WRED stats feature changes on sonic-utilities #2807

rpmarvell commented Apr 24, 2023

stephenxs left a comment

maipbui commented Jun 29, 2023

kperumalbfn Nov 18, 2024

rpmarvell Nov 18, 2024

kperumalbfn Nov 18, 2024

rpmarvell Nov 18, 2024

kperumalbfn commented Jan 15, 2025

mssonicbld commented Jan 17, 2025

azure-pipelines bot commented Jan 17, 2025

rpmarvell commented Jan 17, 2025

kperumalbfn commented Jan 17, 2025

rpmarvell commented Jan 17, 2025

vmittal-msft commented Jan 22, 2025

rpmarvell commented Jan 23, 2025

mssonicbld commented Feb 21, 2025

sonic-utilities: WRED stats feature changes on sonic-utilities #2807

sonic-utilities: WRED stats feature changes on sonic-utilities #2807

Conversation

rpmarvell commented Apr 24, 2023

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

stephenxs left a comment

Choose a reason for hiding this comment

maipbui commented Jun 29, 2023

kperumalbfn Nov 18, 2024

Choose a reason for hiding this comment

rpmarvell Nov 18, 2024

Choose a reason for hiding this comment

kperumalbfn Nov 18, 2024

Choose a reason for hiding this comment

rpmarvell Nov 18, 2024

Choose a reason for hiding this comment

kperumalbfn commented Jan 15, 2025

mssonicbld commented Jan 17, 2025

azure-pipelines bot commented Jan 17, 2025

rpmarvell commented Jan 17, 2025

kperumalbfn commented Jan 17, 2025

rpmarvell commented Jan 17, 2025

vmittal-msft commented Jan 22, 2025

rpmarvell commented Jan 23, 2025

mssonicbld commented Feb 21, 2025