Skip to content

[202012][device/celestica]: Fix failed test cases of Haliburton platform API #8297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mudsut4ke
Copy link
Contributor

- Why I did it

  • To fix failed test cases of Haliburton platform APIs that found on platform_tests script of 202012 version

- How I did it

  1. Add device/celestica/x86_64-cel_e1031-r0/platform.json
  2. Update functions to support python3.7
  3. Add more functions follow latest sonic_platform_base
  4. Fix the bug

- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 202012

Signed-off-by: Wirut Getbamrung [[email protected]]

…onic-net#7579)

- Why I did it
To fix failed test cases of Haliburton platform APIs that found on platform_tests script
- How I did it
Add device/celestica/x86_64-cel_e1031-r0/platform.json
Update functions to support python3.7
Add more functions follow latest sonic_platform_base
Fix the bug
- How to verify it
Run platform_tests script

Signed-off-by: Wirut Getbamrung [[email protected]]
@yxieca yxieca requested a review from sujinmkang August 2, 2021 21:14
@sujinmkang
Copy link
Collaborator

Looks good to me.

@sujinmkang sujinmkang requested a review from prgeor August 2, 2021 22:34
@@ -0,0 +1,108 @@
#!/usr/bin/env python
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this python3?

@lguohan
Copy link
Collaborator

lguohan commented Aug 11, 2021

@mudsut4ke , can you get this pr to master branch and then we can backport to 202012 branch?

@mudsut4ke
Copy link
Contributor Author

mudsut4ke commented Aug 13, 2021

@mudsut4ke , can you get this pr to master branch and then we can backport to 202012 branch?

@lguohan , I already has PR to master branch #7579
But Ying said that the change on platform.json will break 202012 build due to platform.json format differences. #7579 (comment)

So I created this PR with change on platform.json for 202012 version

@lguohan lguohan merged commit 347d726 into sonic-net:202012 Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants