Upgrade tests #97
Merged
Upgrade tests #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nilekh Chaudhari <[email protected]>
aramase
reviewed
Jun 2, 2021
aramase
reviewed
Jun 2, 2021
| CLIENT_SECRET: $(AZURE_CLIENT_SECRET) | ||
|
|
||
| - script: | | ||
| . scripts/setup-kind-cluster.sh & |
There was a problem hiding this comment.
This can be replaced with make e2e-setup-kind
There was a problem hiding this comment.
Done. Though had to move from wait to sleep. It seems ADO does not wait for child process and marks task as done after 10s.
| imageVersion: $(LATEST_KMS_VERSION) | ||
|
|
||
| - script: | | ||
| . scripts/setup-kind-cluster.sh & |
There was a problem hiding this comment.
This can be replaced with make e2e-setup-kind
There was a problem hiding this comment.
In upgrade we can't use this target since it depends on setup-local-registry. This generates also generates the manifests. For upgrade test we want to keep setup, manifest and cluster creation separate to make sure we install right version of kms
aramase
reviewed
Jun 3, 2021
aramase
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Implements e2e upgrade tests
Issue Fixed:
fixes #88
fixes #90
Notes for Reviewers: