Skip to content

ci: enable golangci-lint #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2021
Merged

ci: enable golangci-lint #76

merged 1 commit into from
Feb 10, 2021

Conversation

aramase
Copy link
Member

@aramase aramase commented Feb 10, 2021

Reason for Change:

  • Enable lint as part of CI

Issue Fixed:

Notes for Reviewers:

@aramase aramase force-pushed the golangci-lint branch 2 times, most recently from 3591951 to 5ae6698 Compare February 10, 2021 01:34
@aramase aramase requested a review from ritazh February 10, 2021 01:37
@aramase aramase added this to the v0.0.11 milestone Feb 10, 2021
sozercan
sozercan reviewed Feb 10, 2021
View reviewed changes
@aramase aramase requested a review from sozercan February 10, 2021 17:17
sozercan
sozercan approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aramase aramase merged commit bf10679 into Azure:master Feb 10, 2021
@aramase aramase deleted the golangci-lint branch February 10, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sozercan sozercan sozercan approved these changes

@ritazh ritazh Awaiting requested review from ritazh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.11
Development

Successfully merging this pull request may close these issues.
2 participants
@aramase @sozercan