feat: add byok support and refactor #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aramase
force-pushed
the
byok
branch
11 times, most recently
from
575252d to
a551a9d
Compare
|
Sample log: ➜ kubectl logs azure-kms-provider-k8s-master-20554482-0 -n kube-system -f
I0116 01:22:12.188341 1 main.go:56] "Starting KeyManagementServiceServer service" version="byok01" buildDate="2021-01-15-17:12"
I0116 01:22:12.386847 1 keyvault.go:133] "using kms key for encrypt/decrypt" vaultName="aokvrjbpab47fxymu" keyName="k8s" keyVersion="262067a9e8ba401aa8a746c5f1a7e147"
I0116 01:22:12.387447 1 main.go:82] Listening for connections on address: /opt/azurekms.socket
I0116 01:23:38.736659 1 server.go:56] encrypt request complete
I0116 01:23:42.818829 1 server.go:56] encrypt request complete
I0116 01:23:50.169612 1 server.go:56] encrypt request complete |
ritazh
reviewed
Jan 25, 2021
ritazh
reviewed
Jan 25, 2021
ritazh
reviewed
Jan 25, 2021
pkg/utils/grpc.go
Outdated
|
|
||
| func LogGRPC(ctx context.Context, req interface{}, info *grpc.UnaryServerInfo, handler grpc.UnaryHandler) (interface{}, error) { | ||
| klog.V(2).Infof("GRPC call: %s", info.FullMethod) | ||
| klog.V(2).Infof("GRPC request: %v", req) |
There was a problem hiding this comment.
we should increase the verbosity of these logs as it can contain sensitive data. we should also see if we need to mask anything here.
There was a problem hiding this comment.
The request and response for this doesn't contain much information other than the plain and cipher text. Both are information that we don't want to log at any levels. So I've removed that and added logs in the methods to log start and end.
ritazh
reviewed
Jan 25, 2021
ritazh
reviewed
Jan 25, 2021
|
@ritazh I've taken another pass to add more appropriate logs with redacted client information. PTAL when you get a chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
k8s.io/apiserverIssue Fixed:
fixes #55
fixes #59
fixes #63
Notes for Reviewers: