Skip to content

Support Address space update on peered VNET - Update VirtualNetwork from v1api20201101 #4224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SaschaJohn opened this issue Aug 28, 2024 · 4 comments · Fixed by #4431
Closed
Assignees
Labels
new-resouce-version New version of a resource ASO already supports
Milestone

Comments

@SaschaJohn
Copy link

Describe the current behavior
adding addressPrefixes in an existing VNet with peerings results in an error
MinimumApiVersionNotSpecifiedForAddressSpaceUpdateInPeeredVnet

Address space update operation on virtual network can not be performed as the minimum required API version for working with Vnet Peering is 2021-01-01, and the provided client API version is 2020-11-01.: PUT https://management.azure.com/subscriptions/.../resourceGroups/rg-aks/providers/Microsoft.Network/virtualNetworks/vnet-aks-001

Describe the improvement
Update API version for VirtualNetwork from current v1api20201101 to min v1api20210101

@theunrepentantgeek
Copy link
Member

Latest stable version appears to be 2023-11-01.

@theunrepentantgeek theunrepentantgeek added new-resource Requests for new supported resources new-resouce-version New version of a resource ASO already supports labels Aug 30, 2024
@matthchr
Copy link
Member

matthchr commented Aug 30, 2024

I think there's a 2024-01-01. I noticed this was way out of date when doing work on #4119. I can take this one and try to get it in for 2.10.

I think Networking has changed the way they version their APIs so that every resource is in every API version, which makes it way easier to keep things up to date because you can just update everything to the latest version rather than having to manually figure out if there was a new version published for every resource type.

@matthchr matthchr modified the milestones: v2.10.0, v2.11.0 Oct 18, 2024
@matthchr
Copy link
Member

Begrudgingly pushing this to 2.11, I meant to get it in to 2.10 but we're past due and I haven't had time yet.

It should make 2.11 though as I have it partially done locally... 2.11 will be a short release cycle too (sometime mid Nov is current thinking)

@matthchr matthchr removed the new-resource Requests for new supported resources label Oct 28, 2024
matthchr added a commit to matthchr/azure-service-operator that referenced this issue Nov 12, 2024
Updated the following resources API versions:

Updated to v1api20240301

* BastionHost
* NatGateway
* PublicIPPrefix
* PrivateEndpoint
* PrivateLinkService
* PrivateEndpoints_PrivateDnsZoneGroup
* LoadBalancers_InboundNatRule
* LoadBalancer
* NetworkInterface
* NetworkSecurityGroup
* NetworkSecurityGroups_SecurityRule
* PublicIPAddress
* RouteTable
* RouteTables_Route
* VirtualNetwork
* VirtualNetworkGateway
* VirtualNetworks_Subnet
* VirtualNetworks_VirtualNetworkPeering

Updated to v1api20240601

* PrivateDnsZone
* PrivateDnsZones_VirtualNetworkLink
* PrivateDnsZones_A
* PrivateDnsZones_AAAA
* PrivateDnsZones_CNAME
* PrivateDnsZones_MX
* PrivateDnsZones_SRV
* PrivateDnsZones_PTR
* PrivateDnsZones_TXT

This fixes Azure#4224.
github-merge-queue bot pushed a commit that referenced this issue Nov 12, 2024
Updated the following resources API versions:

Updated to v1api20240301

* BastionHost
* NatGateway
* PublicIPPrefix
* PrivateEndpoint
* PrivateLinkService
* PrivateEndpoints_PrivateDnsZoneGroup
* LoadBalancers_InboundNatRule
* LoadBalancer
* NetworkInterface
* NetworkSecurityGroup
* NetworkSecurityGroups_SecurityRule
* PublicIPAddress
* RouteTable
* RouteTables_Route
* VirtualNetwork
* VirtualNetworkGateway
* VirtualNetworks_Subnet
* VirtualNetworks_VirtualNetworkPeering

Updated to v1api20240601

* PrivateDnsZone
* PrivateDnsZones_VirtualNetworkLink
* PrivateDnsZones_A
* PrivateDnsZones_AAAA
* PrivateDnsZones_CNAME
* PrivateDnsZones_MX
* PrivateDnsZones_SRV
* PrivateDnsZones_PTR
* PrivateDnsZones_TXT

This fixes #4224.
@github-project-automation github-project-automation bot moved this from Backlog to Recently Completed in Azure Service Operator Roadmap Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-resouce-version New version of a resource ASO already supports
Projects
3 participants