Skip to content

Board Review: Easm Mgmt Plane Namespace Review #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nathanfalke opened this issue Feb 3, 2023 · 14 comments
Closed

Board Review: Easm Mgmt Plane Namespace Review #5499

nathanfalke opened this issue Feb 3, 2023 · 14 comments
Assignees
Labels
architecture board-review Request for an Architectural Board Review

Comments

@nathanfalke
Copy link
Member

Contacts and Timeline

About the Service

About the client library

suggested management client name:

  • Name of the client library: easm
@nathanfalke nathanfalke added architecture board-review Request for an Architectural Board Review labels Feb 3, 2023
@ronniegeraghty
Copy link
Member

ronniegeraghty commented Feb 7, 2023

Here are the generated namespaces:

  • .NET: Azure.ResourceManager.DefenderEasm
  • Go: sdk/resourcemanager/defender/armdefendereasm
  • Java: azure-resourcemanager-defendereasm
  • JavaScript: @azure/arm-defendereasm
  • Python: azure-mgmt-defendereasm

@nathanfalke please give you sign off on these names with a comment or a 👍reaction.

@m-nash
Copy link
Member

m-nash commented Feb 7, 2023

Easm seems to be a brand name by Microsoft which we typically try to avoid. When looking at the ARM namespace it was odd since the link provided falls under data-plane folder and none of the URI's had provider segments in them.

Can you help clarify whether this is an ARM service and if so what the URI's will be? Typically we see /subscriptions/{subscriptionId}/resourceGroups/{resourceGroupName}/provider/{namespace}/workspaces/{workspaceName} but the highlighted section is missing.

@m-nash
Copy link
Member

m-nash commented Feb 7, 2023

It looks like the dataplane library will keep Easm in the name. In that case its probably best to keep the continuity between the two.

Dotnet is fine with Azure.ResourceManager.DefenderEasm

@nathanfalke
Copy link
Member Author

nathanfalke commented Feb 8, 2023

I was under the impression that a java namespace would look more like com.azure.resourcemanager.defendereasm - am I thinking of something else?

additionally, there's a typo in the Go name - denfender

@ronniegeraghty
Copy link
Member

I was under the impression that a java namespace would look more like com.azure.resourcemanager.defendereasm - am I thinking of something else?

additionally, there's a typo in the Go name - denfender

Fixed the typo in the Go lib name.
In Java the lib name with it's Group ID will be com.azure.resourcemanager.azure-resourcemanager-defendereasm

@ronniegeraghty
Copy link
Member

@nathanfalke if the proposed names look good with the typo fix and the Java name looks good, knowing the group ID will be added, let me know and we can move on to the next phase of the approval process.

@nathanfalke
Copy link
Member Author

com.azure.resourcemanager.azure-resourcemanager-defendereasm

just for a bit of background info here, why is this the choice over com.azure.resourcemanager.defendereasm?
our team is curious about the reasoning behind the repetition

@ronniegeraghty
Copy link
Member

com.azure.resourcemanager.azure-resourcemanager-defendereasm

just for a bit of background info here, why is this the choice over com.azure.resourcemanager.defendereasm? our team is curious about the reasoning behind the repetition

I can ask the Java SDK architects to respond why the Java MGMT Plane SDK name patter is this way.

@ronniegeraghty
Copy link
Member

@nathanfalke, I've just clarified with the Java Architect.
There are two parts to the Java naming.

  1. The Maven Artifact ID: azure-resourcemanager-defendereasm
  2. The package name: com.azure.resourcemanager.defendereasm
    The package name will follow what you suggested.
    Sorry for the confusion. If that looks okay with you, then we can move on to phase 2 of the approval process.

@nathanfalke
Copy link
Member Author

  • .NET: Azure.ResourceManager.DefenderEasm
  • Go: sdk/resourcemanager/defender/armdefendereasm
  • Java: com.azure.resourcemanager.defendereasm (maven artifact id: azure-resourcemanager-defendereasm )
  • JavaScript: @azure/arm-defendereasm
  • Python: azure-mgmt-defendereasm

just to confirm, is this the final set of names? (if so, looks good to me)

@ronniegeraghty
Copy link
Member

  • .NET: Azure.ResourceManager.DefenderEasm
  • Go: sdk/resourcemanager/defender/armdefendereasm
  • Java: com.azure.resourcemanager.defendereasm (maven artifact id: azure-resourcemanager-defendereasm )
  • JavaScript: @azure/arm-defendereasm
  • Python: azure-mgmt-defendereasm

just to confirm, is this the final set of names? (if so, looks good to me)

Yes

@nathanfalke
Copy link
Member Author

moving on to phase 2 of the process sounds good to me

@ronniegeraghty
Copy link
Member

Phase 2 of MGMT Plane Namespace approval process started.

@ronniegeraghty
Copy link
Member

Review completed. Namespaces have been approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture board-review Request for an Architectural Board Review
Projects
None yet
Development

No branches or pull requests

4 participants