Skip to content

Create sync template for azure-sdk-tools #6034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

JimSuplizio
Copy link
Contributor

@JimSuplizio JimSuplizio commented Apr 24, 2023

eng-common-sync.yml pushes changes out from azure-sdk-tools eng/common directory to the list of repositories defined in the Repos variable of the yml. Because there's going to need to be a similar pipeline to for event processor yml files with a different set of repositories, moving the common code into a template was the way to prevent duplication.

Initially, the pipeline had the default pool settings defined at the pipeline level which were used in both CreateSync stage jobs with CreateSyncPRs and VerifyAndMerge setting their own pool. Because we can't define the pipeline level pool in the template, define it in the CreateSync jobs which are the only ones that were using it and didn't have pools defined.

@JimSuplizio JimSuplizio added the Central-EngSys This issue is owned by the Engineering System team. label Apr 24, 2023
@JimSuplizio JimSuplizio requested a review from weshaggard April 24, 2023 16:11
@JimSuplizio JimSuplizio self-assigned this Apr 24, 2023
@JimSuplizio JimSuplizio requested a review from a team as a code owner April 24, 2023 16:11
@JimSuplizio JimSuplizio marked this pull request as draft April 24, 2023 16:13
@JimSuplizio JimSuplizio marked this pull request as ready for review April 24, 2023 16:43
Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine assuming that what you copied over exactly matches (except the one pool move which is fine).

@konrad-jamrozik konrad-jamrozik requested a review from a team April 24, 2023 17:45
@JimSuplizio
Copy link
Contributor Author

Looks fine assuming that what you copied over exactly matches (except the one pool move which is fine).

Everything is exactly the same with the exception of the pipeline level pool declaration and having to change the sync-directory.yml path from a relative path to an absolute one. The latter being necessary because the template was in a different location.

@JimSuplizio
Copy link
Contributor Author

Since there's no pipeline testing this to appease check-enforcer I'm going to override and merge.

@JimSuplizio
Copy link
Contributor Author

/check-enforcer override

@JimSuplizio JimSuplizio merged commit 9e5d662 into Azure:main Apr 24, 2023
@JimSuplizio JimSuplizio deleted the EngRepoSyncTemplate branch April 24, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants