Skip to content

Migrate SkipDefaultCheckout to SkipCheckoutNone #4042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Sep 1, 2022

Conversation

benbp
Copy link
Member

@benbp benbp commented Aug 31, 2022

Attempting to find a name for this parameter that causes less confusion

@benbp benbp requested review from sima-zhu, weshaggard and a team as code owners August 31, 2022 20:50
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Aug 31, 2022
@benbp benbp self-assigned this Aug 31, 2022
@benbp benbp requested review from scbedd and JimSuplizio August 31, 2022 20:50
@@ -8,13 +8,17 @@ parameters:
- Name: $(Build.Repository.Name)
Commitish: $(Build.SourceVersion)
WorkingDirectory: $(System.DefaultWorkingDirectory)
# NOTE: SkipDefaultCheckout is being deprecated in favor of SkipCheckoutNone
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm keeping both to make it easier to do PRs one by one in the other repositories. After I'm done, I'll remove this parameter.

@azure-sdk
Copy link
Collaborator

The following pipelines have been queued for testing:
java - template
java - template - tests
js - template
net - template
net - template - tests
python - template
python - template - tests
You can sign off on the approval gate to test the release stage of each pipeline.
See eng/common workflow

Copy link
Member

@scbedd scbedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally was like

eugh

to the name. Then I read the variable, and I can't really hate anymore. It's definitely clearer now than it was.

@ghost
Copy link

ghost commented Sep 1, 2022

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 32b98c1 into Azure:main Sep 1, 2022
@benbp benbp deleted the benbp/skip-checkout-none branch September 1, 2022 21:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants