Fix non-awaited async call within a test #49431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
commented
Apr 16, 2025
scbedd
commented
Apr 16, 2025
|
API change check API changes are not detected in this pull request. |
|
/azp run net - ai - projects - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JoshLove-msft
approved these changes
Apr 16, 2025
jsquire
approved these changes
Apr 16, 2025
nick863
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The failure I'm investigating for #48772 seemed really really consistent.
Once I noticed the consistency of the failure it took me only a few seconds to create a fix. Let's run these tests a few times and confirm!
3 test runs of this package and no failures. This was the issue.