Neon GA release dotnet SDK #49390
Neon GA release dotnet SDK #49390
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
alluri02
requested review from
ArcturusZhang,
ArthurMa1978 and
jsquire
as code owners
|
"These are not ARM IDs; these IDs are returned by the Partner API. For example: org-autumn-queen-14745070, ancient-moon-78735937, etc." |
|
Our team develops integrations for third-party ISV partners in the Azure Marketplace. In most cases, the naming conventions are driven by the partners themselves to ensure consistency and familiarity for end users. |
There was a problem hiding this comment.
Your account lacks the public GitHub organization memberships for "Azure" and "Microsoft" required of an internal contributor. (You have these memberships, but you've marked them private.)
Please review the Azure SDK onboarding documentation and use the associated Teams channel for support.
- Azure SDK onboarding (Microsoft internal)
- Azure SDK onboarding assistance (Microsoft internal)
You can verify the state of your account by running the Validate-AzsdkCodeOwner script from the Azure SDK tools repository.
Please also be sure to add yourself to CODEOWNERS for this library, if you will be maintaining it going forward.
Done |
…o neon-ga-release-dotnet
…o neon-ga-release-dotnet
|
As per this comment, I have raised the PR in the Public Spec - Azure/azure-rest-api-specs#34043 |
| ## 1.0.0-beta.2 (Unreleased) | ||
| ## 1.0.0-beta.1 (Unreleased) | ||
|
|
||
| ### Features Added | ||
|
|
||
| ### Breaking Changes | ||
|
|
||
| ### Bugs Fixed | ||
|
|
||
| ### Other Changes | ||
|
|
||
| ## 1.0.0-beta.1 (2024-11-22) |
There was a problem hiding this comment.
I think this change is incorrect
Please revert this and add some briefs about your changes in this PR in 1.0.0-beta.2
| @@ -24,4 +16,4 @@ This package follows the [new Azure SDK guidelines](https://azure.github.io/azur | |||
|
|
|||
| This package is a Public Preview version, so expect incompatible changes in subsequent releases as we improve the product. To provide feedback, submit an issue in our [Azure SDK for .NET GitHub repo](https://github.com/Azure/azure-sdk-for-net/issues). | |||
|
|
|||
| > NOTE: For more information about unified authentication, please refer to [Microsoft Azure Identity documentation for .NET](https://learn.microsoft.com/dotnet/api/overview/azure/identity-readme?view=azure-dotnet). | |||
| > NOTE: For more information about unified authentication, please refer to [Microsoft Azure Identity documentation for .NET](https://docs.microsoft.com//dotnet/api/overview/azure/identity-readme?view=azure-dotnet). | |||
There was a problem hiding this comment.
| > NOTE: For more information about unified authentication, please refer to [Microsoft Azure Identity documentation for .NET](https://docs.microsoft.com//dotnet/api/overview/azure/identity-readme?view=azure-dotnet). | |
| > NOTE: For more information about unified authentication, please refer to [Microsoft Azure Identity documentation for .NET](https://docs.microsoft.com/dotnet/api/overview/azure/identity-readme?view=azure-dotnet). |
| /// A class representing the Branch data model. | ||
| /// The Branch resource type. | ||
| /// </summary> | ||
| public partial class BranchData : ResourceData |
There was a problem hiding this comment.
I saw you have a PR to update the client.tsp: Azure/azure-rest-api-specs#34043
but the name here is not changed.
Could we update your commit to point to the head commit of your PR and regenerate everything here?
| ### Features Added | ||
|
|
||
| ### Breaking Changes | ||
|
|
||
| ### Bugs Fixed | ||
|
|
||
| ### Other Changes | ||
|
|
||
| ## 1.0.0-beta.1 (2024-11-22) |
There was a problem hiding this comment.
we should not remove the previous version, and we should have something in the subsections to describe your changes in this PR (remove empty subsections)
it looks like:
## 1.0.0-beta.2 (Unreleased)
### Features Added
- describe your changes here
## 1.0.0-beta.1 (2024-11-22)
Also please update the Unreleased with your desired release date.
| <PropertyGroup> | ||
| <Version>1.0.0-beta.2</Version> | ||
| <Version>1.0.0-beta.1</Version> |
There was a problem hiding this comment.
the version 1.0.0-beta.1 has been released.
we should revert this back.
| System.Collections.Generic.IEnumerator<Azure.ResourceManager.NeonPostgres.BranchResource> System.Collections.Generic.IEnumerable<Azure.ResourceManager.NeonPostgres.BranchResource>.GetEnumerator() { throw null; } | ||
| System.Collections.IEnumerator System.Collections.IEnumerable.GetEnumerator() { throw null; } | ||
| } | ||
| public partial class BranchData : Azure.ResourceManager.Models.ResourceData, System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.NeonPostgres.BranchData>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.NeonPostgres.BranchData> |
There was a problem hiding this comment.
Did we apply the new changed specs here? The name still does not change.
There was a problem hiding this comment.
Thanks for investigating the duplicate model issue, i have raised a PR - Azure/azure-rest-api-specs#34283
…o neon-ga-release-dotnet
…o neon-ga-release-dotnet
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
…o neon-ga-release-dotnet
…o neon-ga-release-dotnet
| - Support Change Plan | ||
| - Create Neon Project during Neon Organization | ||
| - Create Neon Project from Overview | ||
| - Create Neon Branch | ||
| - Get Neon Database Connection URI | ||
| - List Neon Projects, Branches, Databases, Roles, Endpoints |
There was a problem hiding this comment.
could we also include a line about the api-version upgrade?
…o neon-ga-release-dotnet
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.